Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755924AbZJAJPP (ORCPT ); Thu, 1 Oct 2009 05:15:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755345AbZJAJPO (ORCPT ); Thu, 1 Oct 2009 05:15:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54879 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755342AbZJAJPN (ORCPT ); Thu, 1 Oct 2009 05:15:13 -0400 Date: Thu, 1 Oct 2009 11:12:18 +0200 From: "Michael S. Tsirkin" To: Christian Borntraeger Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Rusty Russell Subject: Re: [PATCH 31/34] move virtrng_remove to .devexit.text Message-ID: <20091001091218.GE5718@redhat.com> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-31-git-send-email-u.kleine-koenig@pengutronix.de> <200910011044.48293.borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200910011044.48293.borntraeger@de.ibm.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 31 On Thu, Oct 01, 2009 at 10:44:48AM +0200, Christian Borntraeger wrote: > Am Donnerstag 01 Oktober 2009 10:28:35 schrieb Uwe Kleine-K?nig: > > The function virtrng_remove is used only wrapped by __devexit_p so define > > it using __devexit. > > > > Signed-off-by: Uwe Kleine-K?nig > > Acked-by: Sam Ravnborg > > Cc: Rusty Russell > > Cc: Michael S. Tsirkin > > Cc: Christian Borntraeger > > Acked-by: Christian Borntraeger FWIW Acked-by: Michael S. Tsirkin > It seems that there are similar changes possible in other virtio drivers (e.g. > virtio_net). Yes, and more importantly drivers/virtio/virtio.c as well. > > [...] > > -static void virtrng_remove(struct virtio_device *vdev) > > +static void __devexit virtrng_remove(struct virtio_device *vdev) > [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/