Date: Thu, 1 Oct 2009 15:45:56 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Greg KH <greg@kroah.com>
cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers-core: nullify private pointer on device-release
In-Reply-To: <20091001132709.GA2221@kroah.com>
Message-ID: <Pine.LNX.4.64.0910011533220.4408@axis700.grange>
References: <Pine.LNX.4.64.0910010950330.4408@axis700.grange>
 <20091001132709.GA2221@kroah.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1079
Lines: 30

On Thu, 1 Oct 2009, Greg KH wrote:

> On Thu, Oct 01, 2009 at 10:02:08AM +0200, Guennadi Liakhovetski wrote:
> > Device structures can be reused over multiple device_add / device_release 
> > cycles.
> 
> They shouldn't be as they should be dynamic, not static.

Should they? I'm pretty sure this is not the first time this comes up - 
there are several drivers and / or subsystems, that re-use driver objects. 
But finding in mail archives wouldn't be very easy. And it worked until 
now - why should we break it?

> What device is having this problem?

My problem case is the soc-camera framework. There device struct is 
embedded into the video client object, which are kept as long as the 
driver is loaded.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/