Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbZJAOzY (ORCPT ); Thu, 1 Oct 2009 10:55:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754758AbZJAOzW (ORCPT ); Thu, 1 Oct 2009 10:55:22 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:43624 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbZJAOzR (ORCPT ); Thu, 1 Oct 2009 10:55:17 -0400 Date: Thu, 1 Oct 2009 16:55:11 +0200 From: Ingo Molnar To: Linus Torvalds Cc: Borislav Petkov , Borislav Petkov , Andi Kleen , x86@kernel.org, Linux Kernel Mailing List Subject: Re: x86: mce: Please revert 22223c9b417be5fd0ab2cf9ad17eb7bd1e19f7b9 Message-ID: <20091001145511.GA20933@elte.hu> References: <20090930140904.GA6150@one.firstfloor.org> <20090930194049.GA17712@liondog.tnic> <20090930204643.GA24862@elte.hu> <20090930214859.GA28638@elte.hu> <20090930223956.GE17712@liondog.tnic> <20090930230947.GA9346@elte.hu> <20091001141432.GA11410@aftab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 39 * Linus Torvalds wrote: > On Thu, 1 Oct 2009, Borislav Petkov wrote: > > > > Ok, here it is, tested on two Fam10 machines here with injecting > > MCEs. The decoding code is now built-in by default (early_initcall > > requires !MODULE). > > I don't think it has to require !MODULE. We could do what we do for > the other initcalls, ie if MODULE we turn it into just a regular > initcall. If that allows something like the EDAC MCE to be built as a > module, and people want to, then just go ahead and add the one-liner > to > > Of course, if it _requires_ being loaded early for some other reason, > then that's a different issue. [...] i think it's borderline. The one issue that makes it nice to be core code is the fact that many hardware problems hit early during bootup, so having the human-readable decoder there has practical advantages. I'd still like to see it nicely abstracted out, and not hardwired into lowlevel code. I.e. we should slowly move towards having proper chipset drivers in the long run. (the fact that northbridges now sit on the CPU die make this easier - there's fewer variations in practice.) ( One detail: if the MODULE=y case is allowed, the unregister side of the callback has to be implemented. That could be .33 material i suspect. ) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/