Message-ID: <4AC4D93C.4030703@kernel.org>
Date: Fri, 02 Oct 2009 01:30:52 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.22 (X11/20090605)
MIME-Version: 1.0
To: David Howells <dhowells@redhat.com>
CC: Jeff Garzik <jeff@garzik.org>, mingo@elte.hu, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org, jens.axboe@oracle.com, rusty@rustcorp.com.au,
       cl@linux-foundation.org, arjan@linux.intel.com
Subject: Re: [PATCH 10/19] workqueue: update cwq alignement and make one more
 flag bit available
References: <4AC4D595.2070202@garzik.org> <1254384558-1018-11-git-send-email-tj@kernel.org> <1254384558-1018-1-git-send-email-tj@kernel.org> <10133.1254402320@redhat.com> <15216.1254414054@redhat.com>
In-Reply-To: <15216.1254414054@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1004
Lines: 27

David Howells wrote:
> Jeff Garzik <jeff@garzik.org> wrote:
> 
>> The quoted code is a standard kernel technique for creating typed constants
>> that are visible to the C compiler (rather than CPP) and debugger.
>>
>> It is found in a great many Linux kernel drivers at this point, and is
>> definitely not abuse, IMO.
> 
> Just because it's common practice, and just because you like it, doesn't make
> it not abuse.  But that's a side issue, and fairly irrelevant to the actual
> implementation.

Yeap, that's something I picked up from Jeff while working on libata
and I'm quite fond of it.  I haven't encountered any downside of it
yet.  Any reason why you think it's an abuse?  But, at any rate, yeap,
it's a pretty peripheral issue.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/