Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756516AbZJAUF0 (ORCPT ); Thu, 1 Oct 2009 16:05:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756446AbZJAUFY (ORCPT ); Thu, 1 Oct 2009 16:05:24 -0400 Received: from g1t0028.austin.hp.com ([15.216.28.35]:27263 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756056AbZJAUFT (ORCPT ); Thu, 1 Oct 2009 16:05:19 -0400 Date: Thu, 1 Oct 2009 14:05:22 -0600 From: Alex Chiang To: Danny Feng Cc: lenb@kernel.org, bjorn.helgaas@hp.com, andrew.patterson@hp.com, jbarnes@virtuousgeek.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: pci_root: fix NULL pointer deref after resume from suspend Message-ID: <20091001200522.GF31915@ldl.fc.hp.com> References: <1254119480-9730-1-git-send-email-dfeng@redhat.com> <20090928173819.GA2441@ldl.fc.hp.com> <4AC16682.50207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC16682.50207@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3804 Lines: 104 Hi Danny, * Danny Feng : > Call Trace: > [] acpi_get_pci_dev+0x106/0x167 > [] acpi_pci_bind+0x1c/0x86 > [] ? sysfs_create_file+0x2a/0x2c > [] acpi_add_single_object+0x964/0xa0c > [] acpi_bus_check_add+0xe0/0x138 > [] acpi_bus_scan+0x68/0xa0 > [] acpi_bus_add+0x2a/0x2e > [] hotplug_dock_devices+0x114/0x13e > [] acpi_dock_deferred_cb+0xbf/0x192 > [] acpi_os_execute_deferred+0x29/0x36 > [] worker_thread+0x251/0x347 > [] ? worker_thread+0x1fc/0x347 > [] ? acpi_os_execute_deferred+0x0/0x36 > [] ? autoremove_wake_function+0x0/0x39 > [] ? worker_thread+0x0/0x347 > [] kthread+0x7f/0x87 > [] child_rip+0xa/0x20 > [] ? restore_args+0x0/0x30 > [] ? kthread+0x0/0x87 > [] ? child_rip+0x0/0x20 > Code: ff 49 89 fc 41 89 f5 a9 00 ff ff 07 74 11 be 87 00 00 00 48 c7 c7 > 45 6d 5a 81 e8 f6 2b e3 ff 48 c7 c7 30 ab 68 81 e8 29 77 20 00 <49> 8b > 5c 24 28 49 83 c4 28 eb 09 44 39 6b 38 74 10 48 89 c3 48 > RIP [] pci_get_slot+0x4c/0x8c > RSP > CR2: 0000000000000028 > ---[ end trace b5a7793bd9db2a4d ]--- Can you please reproduce with this debug patch? I'm guessing that we're dying because we have a NULL parent device, but I'm curious as to what causes this situation to occur. Thanks. /ac --- diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c index 7338b6a..4c1b128 100644 --- a/drivers/acpi/dock.c +++ b/drivers/acpi/dock.c @@ -126,6 +126,7 @@ add_dock_dependent_device(struct dock_station *ds, { spin_lock(&ds->dd_lock); list_add_tail(&dd->list, &ds->dependent_devices); + printk("%s adding handle %p\n", __func__, dd->handle); spin_unlock(&ds->dd_lock); } @@ -142,6 +143,8 @@ dock_add_hotplug_device(struct dock_station *ds, { mutex_lock(&ds->hp_lock); list_add_tail(&dd->hotplug_list, &ds->hotplug_devices); + dump_stack(); + printk("%s adding handle %p\n", __func__, dd->handle); mutex_unlock(&ds->hp_lock); } @@ -325,14 +328,17 @@ static struct acpi_device * dock_create_acpi_device(acpi_handle handle) acpi_handle parent; int ret; + printk("%s handle %p\n", __func__, handle); if (acpi_bus_get_device(handle, &device)) { /* * no device created for this object, * so we should create one. */ acpi_get_parent(handle, &parent); - if (acpi_bus_get_device(parent, &parent_device)) + if (acpi_bus_get_device(parent, &parent_device)) { parent_device = NULL; + printk("%s no parent, setting NULL\n", __func__); + } ret = acpi_bus_add(&device, parent_device, handle, ACPI_BUS_TYPE_DEVICE); @@ -385,8 +391,10 @@ static void hotplug_dock_devices(struct dock_station *ds, u32 event) * First call driver specific hotplug functions */ list_for_each_entry(dd, &ds->hotplug_devices, hotplug_list) { - if (dd->ops && dd->ops->handler) + if (dd->ops && dd->ops->handler) { + printk("%s handle %p\n", __func__, dd->handle); dd->ops->handler(dd->handle, event, dd->context); + } } /* @@ -1041,6 +1049,7 @@ static int dock_add(acpi_handle handle) ret = -ENOMEM; goto dock_add_err_unregister; } + printk("%s adding self as dependent %p)\n", __func__, dd->handle); add_dock_dependent_device(dock_station, dd); dock_station_count++; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/