Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756579AbZJAUfy (ORCPT ); Thu, 1 Oct 2009 16:35:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756369AbZJAUfx (ORCPT ); Thu, 1 Oct 2009 16:35:53 -0400 Received: from smtp-out.google.com ([216.239.45.13]:29879 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756240AbZJAUfx (ORCPT ); Thu, 1 Oct 2009 16:35:53 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=tkZstLfviX/pqK1YYjU4ziWZYzLP0+s91JFtKcWMiqeqZXKNRJdp/8RvDh3r1KB/o 9fnm3cWIZzK/+Mh7RKhEA== Date: Thu, 1 Oct 2009 13:35:44 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Suresh Jayaraman cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, Neil Brown , Miklos Szeredi , Wouter Verhelst , Peter Zijlstra , trond.myklebust@fys.uio.no Subject: Re: [PATCH 01/31] mm: serialize access to min_free_kbytes In-Reply-To: <1254405871-15687-1-git-send-email-sjayaraman@suse.de> Message-ID: References: <1254405871-15687-1-git-send-email-sjayaraman@suse.de> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 21 On Thu, 1 Oct 2009, Suresh Jayaraman wrote: > From: Peter Zijlstra > > There is a small race between the procfs caller and the memory hotplug caller > of setup_per_zone_wmarks(). Not a big deal, but the next patch will add yet > another caller. Time to close the gap. > By "next patch," you mean "mm: emegency pool" (patch 08/31)? If so, can't you eliminate var_free_mutex entirely from that patch and take min_free_lock in adjust_memalloc_reserve() instead? [ __adjust_memalloc_reserve() would call __setup_per_zone_wmarks() under lock instead, now. ] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/