Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbZJAVJa (ORCPT ); Thu, 1 Oct 2009 17:09:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752486AbZJAVJ2 (ORCPT ); Thu, 1 Oct 2009 17:09:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbZJAVJ1 (ORCPT ); Thu, 1 Oct 2009 17:09:27 -0400 Date: Thu, 1 Oct 2009 17:08:46 -0400 From: Jason Baron To: Joe Perches Cc: LKML , Andrew Morton Subject: Re: [PATCH] dynamic_debug.h/kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug Message-ID: <20091001210846.GE2660@redhat.com> References: <1254342977.2960.114.camel@Joe-Laptop.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254342977.2960.114.camel@Joe-Laptop.home> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 26 On Wed, Sep 30, 2009 at 01:36:17PM -0700, Joe Perches wrote: > If CONFIG_DYNAMIC_DEBUG is enabled and a source file has: > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > #include > > dynamic_debug.h will duplicate KBUILD_MODNAME > in the output string. > > Remove the use of KBUILD_MODNAME from the > output format string generated by dynamic_debug.h > > If CONFIG_DYNAMIC_DEBUG is not enabled, no compile-time > check is done to printk/dev_printk arguments. > > Add it. > looks good. thanks for updating this. Acked-by: Jason Baron -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/