Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338AbZJAV5m (ORCPT ); Thu, 1 Oct 2009 17:57:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752261AbZJAV5m (ORCPT ); Thu, 1 Oct 2009 17:57:42 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:32991 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbZJAV5l (ORCPT ); Thu, 1 Oct 2009 17:57:41 -0400 Date: Thu, 1 Oct 2009 14:57:29 -0700 From: Andrew Morton To: Joe Perches Cc: jbaron@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dynamic_debug.h/kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug Message-Id: <20091001145729.280ffe69.akpm@linux-foundation.org> In-Reply-To: <1254342977.2960.114.camel@Joe-Laptop.home> References: <1254342977.2960.114.camel@Joe-Laptop.home> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6835 Lines: 111 On Wed, 30 Sep 2009 13:36:17 -0700 Joe Perches wrote: > If CONFIG_DYNAMIC_DEBUG is enabled and a source file has: > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > #include > > dynamic_debug.h will duplicate KBUILD_MODNAME > in the output string. > > Remove the use of KBUILD_MODNAME from the > output format string generated by dynamic_debug.h > > If CONFIG_DYNAMIC_DEBUG is not enabled, no compile-time > check is done to printk/dev_printk arguments. > > Add it. x86_64 allmodconfig: crypto/zlib.c: In function 'zlib_compress_update': crypto/zlib.c:148: warning: initialization makes integer from pointer without a cast crypto/zlib.c:148: error: initializer element is not computable at load time crypto/zlib.c:148: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:148: warning: excess elements in struct initializer crypto/zlib.c:148: warning: (near initialization for 'descriptor') crypto/zlib.c:160: warning: initialization makes integer from pointer without a cast crypto/zlib.c:160: error: initializer element is not computable at load time crypto/zlib.c:160: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:160: warning: excess elements in struct initializer crypto/zlib.c:160: warning: (near initialization for 'descriptor') crypto/zlib.c:164: warning: initialization makes integer from pointer without a cast crypto/zlib.c:164: error: initializer element is not computable at load time crypto/zlib.c:164: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:164: warning: excess elements in struct initializer crypto/zlib.c:164: warning: (near initialization for 'descriptor') crypto/zlib.c:169: warning: initialization makes integer from pointer without a cast crypto/zlib.c:169: error: initializer element is not computable at load time crypto/zlib.c:169: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:169: warning: excess elements in struct initializer crypto/zlib.c:169: warning: (near initialization for 'descriptor') crypto/zlib.c: In function 'zlib_compress_final': crypto/zlib.c:186: warning: initialization makes integer from pointer without a cast crypto/zlib.c:186: error: initializer element is not computable at load time crypto/zlib.c:186: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:186: warning: excess elements in struct initializer crypto/zlib.c:186: warning: (near initialization for 'descriptor') crypto/zlib.c:194: warning: initialization makes integer from pointer without a cast crypto/zlib.c:194: error: initializer element is not computable at load time crypto/zlib.c:194: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:194: warning: excess elements in struct initializer crypto/zlib.c:194: warning: (near initialization for 'descriptor') crypto/zlib.c:199: warning: initialization makes integer from pointer without a cast crypto/zlib.c:199: error: initializer element is not computable at load time crypto/zlib.c:199: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:199: warning: excess elements in struct initializer crypto/zlib.c:199: warning: (near initialization for 'descriptor') crypto/zlib.c: In function 'zlib_decompress_update': crypto/zlib.c:262: warning: initialization makes integer from pointer without a cast crypto/zlib.c:262: error: initializer element is not computable at load time crypto/zlib.c:262: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:262: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:262: warning: excess elements in struct initializer crypto/zlib.c:262: warning: (near initialization for 'descriptor') crypto/zlib.c:275: warning: initialization makes integer from pointer without a cast crypto/zlib.c:275: error: initializer element is not computable at load time crypto/zlib.c:275: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:275: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:275: warning: excess elements in struct initializer crypto/zlib.c:275: warning: (near initialization for 'descriptor') crypto/zlib.c:279: warning: initialization makes integer from pointer without a cast crypto/zlib.c:279: error: initializer element is not computable at load time crypto/zlib.c:279: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:279: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:279: warning: excess elements in struct initializer crypto/zlib.c:279: warning: (near initialization for 'descriptor') crypto/zlib.c:284: warning: initialization makes integer from pointer without a cast crypto/zlib.c:284: error: initializer element is not computable at load time crypto/zlib.c:284: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:284: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:284: warning: excess elements in struct initializer crypto/zlib.c:284: warning: (near initialization for 'descriptor') crypto/zlib.c: In function 'zlib_decompress_final': crypto/zlib.c:301: warning: initialization makes integer from pointer without a cast crypto/zlib.c:301: error: initializer element is not computable at load time crypto/zlib.c:301: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:301: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:301: warning: excess elements in struct initializer crypto/zlib.c:301: warning: (near initialization for 'descriptor') crypto/zlib.c:327: warning: initialization makes integer from pointer without a cast crypto/zlib.c:327: error: initializer element is not computable at load time crypto/zlib.c:327: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:327: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:327: warning: excess elements in struct initializer crypto/zlib.c:327: warning: (near initialization for 'descriptor') crypto/zlib.c:332: warning: initialization makes integer from pointer without a cast crypto/zlib.c:332: error: initializer element is not computable at load time crypto/zlib.c:332: error: (near initialization for 'descriptor.primary_hash') crypto/zlib.c:332: warning: large integer implicitly truncated to unsigned type crypto/zlib.c:332: warning: excess elements in struct initializer crypto/zlib.c:332: warning: (near initialization for 'descriptor') make[1]: *** [crypto/zlib.o] Error 1 make: *** [crypto/zlib.o] Error 2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/