Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753486AbZJAWXh (ORCPT ); Thu, 1 Oct 2009 18:23:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753421AbZJAWXh (ORCPT ); Thu, 1 Oct 2009 18:23:37 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:60975 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753407AbZJAWXg (ORCPT ); Thu, 1 Oct 2009 18:23:36 -0400 Date: Thu, 01 Oct 2009 15:23:55 -0700 (PDT) Message-Id: <20091001.152355.209105273.davem@davemloft.net> To: sbhatewara@vmware.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, shemminger@linux-foundation.org, jgarzik@pobox.com, anthony@codemonkey.ws, chrisw@sous-sol.org, greg@kroah.com, akpm@linux-foundation.org, virtualization@lists.linux-foundation.org, pv-drivers@vmware.com Subject: Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3 From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1675 Lines: 58 From: Shreyas Bhatewara Date: Wed, 30 Sep 2009 14:34:57 -0700 (PDT) > +{ > + struct vmxnet3_adapter *adapter = netdev_priv(netdev); > + u8 *base; > + int i; > + > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, > VMXNET3_CMD_GET_STATS); > + > + /* this does assume each counter is 64-bit wide */ > + > + base = (u8 *)&adapter->tqd_start->stats; > + for (i = 0; i < ARRAY_SIZE(vmxnet3_tq_dev_stats); i++) > + *buf++ = *(u64 *)(base + vmxnet3_tq_dev_stats[i].offset); > + > + base = (u8 *)&adapter->tx_queue.stats; > + for (i = 0; i < ARRAY_SIZE(vmxnet3_tq_driver_stats); i++) > + *buf++ = *(u64 *)(base + vmxnet3_tq_driver_stats[i].offset); > + > + base = (u8 *)&adapter->rqd_start->stats; There's a lot of code like this that isn't indented properly. Either that or your email client has corrupted the patch by breaking up long lines or similar. Another example: > +static int > +vmxnet3_set_rx_csum(struct net_device *netdev, u32 val) > +{ > + struct vmxnet3_adapter *adapter = netdev_priv(netdev); > + > + if (adapter->rxcsum != val) { > + adapter->rxcsum = val; > + if (netif_running(netdev)) { > + if (val) > + adapter->shared->devRead.misc.uptFeatures |= > + UPT1_F_RXCSUM; > + else > + adapter->shared->devRead.misc.uptFeatures &= > + ~UPT1_F_RXCSUM; > + > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, > + VMXNET3_CMD_UPDATE_FEATURE); > + } > + } > + return 0; > +} Yikes! :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/