Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756686AbZJBFrB (ORCPT ); Fri, 2 Oct 2009 01:47:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756642AbZJBFrA (ORCPT ); Fri, 2 Oct 2009 01:47:00 -0400 Received: from cantor.suse.de ([195.135.220.2]:52467 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756634AbZJBFrA (ORCPT ); Fri, 2 Oct 2009 01:47:00 -0400 Date: Fri, 02 Oct 2009 07:47:03 +0200 Message-ID: From: Takashi Iwai To: Sven Eckelmann Cc: Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ctxfi: Swapped SURROUND-SIDE mute In-Reply-To: <1254420399-14411-1-git-send-email-sven.eckelmann@gmx.de> References: <1254420399-14411-1-git-send-email-sven.eckelmann@gmx.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 52 At Thu, 1 Oct 2009 20:06:39 +0200, Sven Eckelmann wrote: > > On Soundblaster X-FI Titenium with emu20k2 the SIDE and SURROUND mute > functions are swapped. > It was checked with 'speaker-test -c 8 -s 3' and (un)mute surround or > 'speaker-test -c 8 -s 7' and (un)mute side. The volume seems not > to be affected and works as expected. > > Signed-off-by: Sven Eckelmann > --- > This patch is tested with commit 55fe27f7e2c9d24ce870136bd99ae67b020122d1 > which arranges the channels on emu20k2. Thanks, applied now. Takashi > sound/pci/ctxfi/ctatc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c > index b1b3a64..7545464 100644 > --- a/sound/pci/ctxfi/ctatc.c > +++ b/sound/pci/ctxfi/ctatc.c > @@ -1037,7 +1037,7 @@ static int atc_line_front_unmute(struct ct_atc *atc, unsigned char state) > > static int atc_line_surround_unmute(struct ct_atc *atc, unsigned char state) > { > - return atc_daio_unmute(atc, state, LINEO4); > + return atc_daio_unmute(atc, state, LINEO2); > } > > static int atc_line_clfe_unmute(struct ct_atc *atc, unsigned char state) > @@ -1047,7 +1047,7 @@ static int atc_line_clfe_unmute(struct ct_atc *atc, unsigned char state) > > static int atc_line_rear_unmute(struct ct_atc *atc, unsigned char state) > { > - return atc_daio_unmute(atc, state, LINEO2); > + return atc_daio_unmute(atc, state, LINEO4); > } > > static int atc_line_in_unmute(struct ct_atc *atc, unsigned char state) > -- > 1.6.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/