Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756764AbZJBGGR (ORCPT ); Fri, 2 Oct 2009 02:06:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756720AbZJBGGQ (ORCPT ); Fri, 2 Oct 2009 02:06:16 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:42544 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756654AbZJBGGQ (ORCPT ); Fri, 2 Oct 2009 02:06:16 -0400 To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk References: <20091002012911.GA18542@kroah.com> <20091002051056.GA7181@suse.de> From: ebiederm@xmission.com (Eric W. Biederman) Date: Thu, 01 Oct 2009 23:06:11 -0700 In-Reply-To: <20091002051056.GA7181@suse.de> (Greg KH's message of "Thu\, 1 Oct 2009 22\:10\:56 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in02.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Greg KH X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 XM_SPF_Neutral SPF-Neutral * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.4 UNTRUSTED_Relay Comes from a non-trusted relay Subject: Re: [000/136] 2.6.31.2-stable review X-SA-Exim-Version: 4.2.1 (built Thu, 25 Oct 2007 00:26:12 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2127 Lines: 63 Greg KH writes: > On Thu, Oct 01, 2009 at 10:01:34PM -0700, Eric W. Biederman wrote: >> Greg KH writes: >> >> > Note from the -stable maintainer on this release: >> > >> > This release is big. Yeah, really big. There are a number of >> > areas that needed some rework in order to get things back to >> > working order. Like the tty layer. Hopefully everyone can now >> > use their usb to serial devices again without oopsing the >> > kernel >> >> The ftdi_sio driver still crashes and burns. > > What were you doing when it crashed? I tested the pl2303 device and it > worked fine for me here, I don't have a ftdi_sio one :( The patch that floated on the list earlier does fix the worst of the symptoms. Eric From: Johan Hovold Subject: [PATCH] USB: ftdi_sio: Remove tty->low_latency. Fixes tty_flip_buffer_push being called from hard interrupt context with low_latency set. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 8fec5d4..22b72e8 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1228,7 +1228,6 @@ static int set_serial_info(struct tty_struct *tty, (new_serial.flags & ASYNC_FLAGS)); priv->custom_divisor = new_serial.custom_divisor; - tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0; write_latency_timer(port); check_and_exit: @@ -1699,9 +1698,6 @@ static int ftdi_open(struct tty_struct *tty, priv->rx_bytes = 0; spin_unlock_irqrestore(&priv->rx_lock, flags); - if (tty) - tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0; - write_latency_timer(port); /* No error checking for this (will get errors later anyway) */ -- 1.6.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/