Message-Id: <4AC5C68F0200007800017A3F@vpn.id2.novell.com>
Date: Fri, 02 Oct 2009 08:23:27 +0100
From: "Jan Beulich" <JBeulich@novell.com>
To: "Jeremy Fitzhardinge" <Jeremy.Fitzhardinge@citrix.com>
Cc: "ketuzsezr@darnok.org" <ketuzsezr@darnok.org>,
       "Martin Wilck" <Martin.Wilck@fujitsu-siemens.com>,
       "pjones@redhat.com" <pjones@redhat.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iSCSI/iBFT: use proper address translation
References: <4AC47DED0200007800017743@vpn.id2.novell.com>
 <4AC5234C.5030409@citrix.com>
In-Reply-To: <4AC5234C.5030409@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1155
Lines: 25

>>> Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com> 01.10.09 23:46 >>>
>On 10/01/09 01:01, Jan Beulich wrote:
>> In virtual environments (namely, Xen Dom0) virt <-> phys and
>> virt <-> isa-bus translations cannot be freely interchanged. When
>> looking at memory below 1M, the latter translations should always
>> be used.
>>   
>
>Do you have a different definition for isa_virt_to_bus in your kernel? 
>As far as I can see it is defined to be the same as virt_to_phys.  Also,
>the ISA memory is identity mapped into the domain's physical mapping
>space, so it should be directly accessible without any problems.

I wasn't sure if this is an issue in the pv-ops kernel, so I copied you just
in case. Yes, we do have a different virt<->isa_bus translation, but
the point of the patch really is that virt<->phys translations are
incorrectly being used here regardless of the underlying environment.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/