Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757542AbZJBKGP (ORCPT ); Fri, 2 Oct 2009 06:06:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756831AbZJBKGO (ORCPT ); Fri, 2 Oct 2009 06:06:14 -0400 Received: from adelie.canonical.com ([91.189.90.139]:54943 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756811AbZJBKGN (ORCPT ); Fri, 2 Oct 2009 06:06:13 -0400 Message-ID: <4AC5D098.1010504@canonical.com> Date: Fri, 02 Oct 2009 12:06:16 +0200 From: Stefan Bader User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: Peter Feuerer CC: Borislav Petkov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] acerhdf: Limit modalias matching to supported boards References: <4AC34B83.6090402@canonical.com> <20090930212233.GB17712@liondog.tnic> <4AC5B0F1.4030303@canonical.com> <9ea470500910020254j21fad1d3g1c825bcecdbb29fb@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1936 Lines: 58 Peter Feuerer wrote: > Borislav Petkov writes: > >> On Fri, Oct 2, 2009 at 9:51 AM, Stefan Bader >> wrote: >>>>> I search my acerhdf-inbox for the people who sent me the BIOS >>>>> versions, >>>> maybe they still have the netbook and can me send the modalias >>>> content. I'll >>>> hopefully find some time upcoming weekend. >>>> >>>> But, can't we simply assume, following dmi lines? >>>> >>>> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:"); >>>> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:"); >>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:"); >>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:"); >>>> >>>> We have exactly those constellations within the BIOS settings table. >>>> If I >>>> interpret the modalias line correctly, "pnAOA110" means "Product Name >>>> AOA110" and that's what we have already in the BIOS settings table. >>>> So I >>>> think we do already have all information we need to create a >>>> complete patch >>>> for the problem, or am I wrong? >>> >>> Right pn means that. I would strongly believe the above changes >>> should be >>> good. I sometimes tend to be over-cautious. Attaching a refreshed patch >>> which includes them all. >> >> Well, acerhdf.c and dmi-id.c both do >> dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which >> means that the product names in the acerhdf table and the dmi-id ones >> are actually one and the same thing. >> >> IMO, we should just go ahead send it to Len. Stefan, you have my ACK. > > Will try the patch tomorrow morning and you'll then get also my ack, if > it's working. > > --peter Ok, cool. Will wait on that. -Stefan -- When all other means of communication fail, try words! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/