Message-ID: <4AC5E7BA.5060700@kernel.org>
Date: Fri, 02 Oct 2009 20:44:58 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.22 (X11/20090605)
MIME-Version: 1.0
To: David Howells <dhowells@redhat.com>
CC: jeff@garzik.org, mingo@elte.hu, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org, jens.axboe@oracle.com, rusty@rustcorp.com.au,
       cl@linux-foundation.org, arjan@linux.intel.com
Subject: Re: [RFC PATCHSET] workqueue: implement concurrency managed workqueue
References: <1254384558-1018-1-git-send-email-tj@kernel.org> <9942.1254401629@redhat.com>
In-Reply-To: <9942.1254401629@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1459
Lines: 40

Hello, David Howells.

David Howells wrote:
> Sounds interesting as a replacement for slow-work.  Some thoughts for you:
> 
> The most important features of slow-work are:
> 
>  (1) Work items are not re-entered whilst they are executing.
> 
>  (2) The slow-work facility keeps references on its work items by asking the
>      client to get and put on the client's refcount.
> 
>  (3) The slow-work facility can create a lot more threads than the number of
>      CPUs on a system, and the system doesn't grind to a halt if they're all
>      taken up with long term I/O (performing several mkdirs for example).
> 
> I think you have (1) and (3) covered, but I'm unsure about (2).

Given that slow-work isn't being used too extensively yet, I was
thinking whether that part could be pushed down to the caller.  Or, we
can also wrap work and export an interface which supports the get/put
reference.

> Also, does it actually make sense to bind threads that are
> performing long-term I/O to particular CPUs?  Threads that are going
> to spend a lot more time sleeping on disk I/O than actually running
> on a CPU?

Binding is usually beneficial and doesn't matter for IO intensive
ones, so...

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/