Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbZJBL7z (ORCPT ); Fri, 2 Oct 2009 07:59:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754456AbZJBL7y (ORCPT ); Fri, 2 Oct 2009 07:59:54 -0400 Received: from smtp-out003.kontent.com ([81.88.40.217]:50689 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753625AbZJBL7x (ORCPT ); Fri, 2 Oct 2009 07:59:53 -0400 From: Oliver Neukum To: "Sven-Thorsten Dietrich" Subject: Re: [PATCH][UHCI-DEBUG] Don't kmalloc with BKL held Date: Fri, 2 Oct 2009 14:01:36 +0200 User-Agent: KMail/1.10.3 (Linux/2.6.31-rc9-0.1-default; KDE/4.1.3; x86_64; ; ) Cc: LKML , "linux-rt-users" References: <1254474744.28661.2.camel@sven.thebigcorporation.com> In-Reply-To: <1254474744.28661.2.camel@sven.thebigcorporation.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910021401.37997.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 18 Am Freitag, 2. Oktober 2009 11:12:24 schrieb Sven-Thorsten Dietrich: > Subject: Don't kmalloc with BKL held. > From: Sven-Thorsten Dietrich > > I'm eyeballing this file for complete removal of lock_kernel but > at first glance, we definitely don't need BKL to kmalloc(). The reasoning is correct, but this patch screws up the error case. You also need to move the label. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/