DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding:message-id;
        b=Sjty9N5caxqO04onSjIXKbQkWrYLtt56GeC3Cea7lu0YTP+9R/MFZm7LvHq9FHyly1
         5jvbjdJhHsJunR4MVGKNpPwiSvpTGYzUIp/wuK3uNsJF5isbnSTd1p5GENj6BnBQAnLa
         bAUwS3cytTcTRp5FABN1j2i/J1jcEnru6AcAk=
From: Corentin Chary <corentincj@iksaif.net>
To: Rakib Mullick <rakib.mullick@gmail.com>
Subject: Re: [PATCH] eeepc_laptop: Properly annote eeepc_enable_camera().
Date: Fri, 2 Oct 2009 15:35:27 +0200
User-Agent: KMail/1.12.1 (Linux/2.6.31-gentoo; KDE/4.3.1; x86_64; ; )
Cc: acpi4asus-user@lists.sourceforge.net, LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
References: <b9df5fa10910012231u38f49eeeoe1d0bcc9eafd53d6@mail.gmail.com>
In-Reply-To: <b9df5fa10910012231u38f49eeeoe1d0bcc9eafd53d6@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200910021535.27820.corentincj@iksaif.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2598
Lines: 69

On Friday 02 October 2009 07:31:51 Rakib Mullick wrote:
>  Currenlty the annotation for function eeepc_enable_camera() is
> __init, and refers to a function eeepc_hotk_add() which is non-init.
> Use __devinit for both functions which is
>  more appropriate and fixes a section mismatch warning.
> 
>  We were warned by the following warning:
> 
>   LD      drivers/platform/x86/built-in.o
> WARNING: drivers/platform/x86/built-in.o(.text+0x12e1): Section
> mismatch in reference from the function eeepc_hotk_add() to the
> function .init.text:eeepc_enable_camera()
> The function eeepc_hotk_add() references
> the function __init eeepc_enable_camera().
> This is often because eeepc_hotk_add lacks a __init
> annotation or the annotation of eeepc_enable_camera is wrong.
> 
> ----
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> 
> --- linus/drivers/platform/x86/eeepc-laptop.c	2009-09-28
> 12:05:21.000000000 +0600
> +++ rakib/drivers/platform/x86/eeepc-laptop.c	2009-09-29
> 23:40:00.000000000 +0600
> @@ -350,7 +350,7 @@ static const struct rfkill_ops eeepc_rfk
>  	.set_block = eeepc_rfkill_set,
>  };
> 
> -static void __init eeepc_enable_camera(void)
> +static void __devinit eeepc_enable_camera(void)
>  {
>  	/*
>  	 * If the following call to set_acpi() fails, it's because there's no
> @@ -1189,7 +1189,7 @@ static int eeepc_input_init(struct devic
>  	return 0;
>  }
> 
> -static int eeepc_hotk_add(struct acpi_device *device)
> +static int __devinit eeepc_hotk_add(struct acpi_device *device)
>  {
>  	struct device *dev;
>  	int result;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Hi,
Your patch is broken, probably due to wordwrap.

$ git am /tmp/\[PATCH\]\ eeepc_laptop\:\ Properly\ annote\ eeepc_enable_camera\(\)
Applying: eeepc_laptop: Properly annote eeepc_enable_camera().
fatal: patch fragment without header at line 5: @@ -350,7 +350,7 @@ static const struct rfkill_ops eeepc_rfk
Patch failed at 0001 eeepc_laptop: Properly annote eeepc_enable_camera().

Please re-send it (you can use git send-emails).
Also, please name it eeepc-laptop, not eeepc_laptop
Thanks,

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/