Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755554AbZJBQxo (ORCPT ); Fri, 2 Oct 2009 12:53:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753404AbZJBQxn (ORCPT ); Fri, 2 Oct 2009 12:53:43 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41953 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753075AbZJBQxm (ORCPT ); Fri, 2 Oct 2009 12:53:42 -0400 Date: Fri, 02 Oct 2009 09:54:02 -0700 (PDT) Message-Id: <20091002.095402.42770342.davem@davemloft.net> To: khali@linux-fr.org Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, rdunlap@xenotime.net, stable@kernel.org Subject: Re: [PATCH] net: Fix wrong sizeof From: David Miller In-Reply-To: <20091002113038.1dc3d284@hyperion.delvare> References: <20091002113038.1dc3d284@hyperion.delvare> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 19 From: Jean Delvare Date: Fri, 2 Oct 2009 11:30:38 +0200 > Which is why I have always preferred sizeof(struct foo) over > sizeof(var). > > Signed-off-by: Jean Delvare > Cc: Randy Dunlap Any time you see "&" in a sizeof() expression, it's almost certainly a bug. Something for the folks with automated tools to look for if they haven't already :-) I'll apply this, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/