Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755006AbZJCKw5 (ORCPT ); Sat, 3 Oct 2009 06:52:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754791AbZJCKw5 (ORCPT ); Sat, 3 Oct 2009 06:52:57 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:45002 "EHLO mail-ew0-f211.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754553AbZJCKw4 (ORCPT ); Sat, 3 Oct 2009 06:52:56 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=aUGoUDSxgPHSX1RS0VDuisz0R6XzAMm3/UpmlswO/dMhKhqcJCnskUnFMRC72q1Y75 2cGCpGL4cXeHrR52AKe1MmNDJbh2WKZ6QcFsda4mBWKYgMDJd2ZRmmuqCf4x9L01Kg2A SiqEa8kfQ+lTwVQwUKy5GEeEsXYfmYQgCtbG8= Message-ID: <4AC72D09.3040907@tuffmail.co.uk> Date: Sat, 03 Oct 2009 11:52:57 +0100 From: Alan Jenkins User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: Jesse Barnes CC: Eric Anholt , Matthew Garrett , linux acpi , linux-kernel Subject: 2.6.32-rc1: spurious error message from "ACPI button: provide lid status functions" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1881 Lines: 53 ACPI: Waking up from system sleep state S4 PM: Device PNP0C0D:00 failed to thaw: error 1 The device appears to be the acpi lid "button". The error comes from calling acpi_lid_send_state(): @@ -242,7 +272,12 @@ static int acpi_lid_send_state(struct acpi_device *device) /* input layer checks if event is redundant */ input_report_switch(button->input, SW_LID, !state); input_sync(button->input); - return 0; + + ret = blocking_notifier_call_chain(&acpi_lid_notifier, state, device); + if (ret == NOTIFY_DONE) + ret = blocking_notifier_call_chain(&acpi_lid_notifier, state, + device); + return ret; } The "error 1" is actually NOTIFY_OK. @include/linux/notify.h: #define NOTIFY_DONE 0x0000 /* Don't care */ #define NOTIFY_OK 0x0001 /* Suits me */ #define NOTIFY_STOP_MASK 0x8000 /* Don't call further */ #define NOTIFY_BAD (NOTIFY_STOP_MASK|0x0002) /* Bad/Veto action */ /* * Clean way to return from the notifier and stop further calls. */ #define NOTIFY_STOP (NOTIFY_OK|NOTIFY_STOP_MASK) Clearly acpi_lid_send_state() should return 0 for NOTIFY_OK. I guess NOTIFY_STOP can be ignored until someone says they need it. But I don't understand the NOTIFY_DONE case, so I'm not sure. I can't find any users to reverse engineer it. IMO it either needs to be removed or commented. Can you please sort this out, so we don't see this error message on a completely successful resume? Thanks! Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/