Message-ID: <3C980A11.AD5A7660@zip.com.au>
Date: Tue, 19 Mar 2002 20:03:29 -0800
From: Andrew Morton <akpm@zip.com.au>
MIME-Version: 1.0
To: lkml <linux-kernel@vger.kernel.org>
Subject: aa-200-active_page_swapout
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Last one.


Don't bother checking for active pages in the swapout path.

Not sure about this one.  Clearly the page isn't *likely* to be on the
active list, because the caller found it on the inactive list.  But I
don't see any locking which would prevent the page from getting bumped
up to the active list in the meanwhile.

Needs more explanation.


=====================================

--- 2.4.19-pre3/mm/vmscan.c~aa-200-active_page_swapout	Tue Mar 19 19:49:04 2002
+++ 2.4.19-pre3-akpm/mm/vmscan.c	Tue Mar 19 19:49:04 2002
@@ -83,10 +83,6 @@ static inline int try_to_swap_out(struct
 		return 0;
 	}
 
-	/* Don't bother unmapping pages that are active */
-	if (PageActive(page))
-		return 0;
-
 	/* Don't bother replenishing zones not under pressure.. */
 	if (!memclass(page_zone(page), classzone))
 		return 0;

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/