Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756856AbZJCS1J (ORCPT ); Sat, 3 Oct 2009 14:27:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756806AbZJCS1I (ORCPT ); Sat, 3 Oct 2009 14:27:08 -0400 Received: from bu3sch.de ([62.75.166.246]:59679 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756789AbZJCS1I (ORCPT ); Sat, 3 Oct 2009 14:27:08 -0400 From: Michael Buesch To: Tilman Schmidt Subject: Re: [PATCH RFC] isdn/capi: fix up CAPI subsystem workaround locking a bit Date: Sat, 3 Oct 2009 20:26:22 +0200 User-Agent: KMail/1.9.9 Cc: i4ldeveloper@listserv.isdn4linux.de, Carsten Paeth , Karsten Keil , Karsten Keil , Armin Schindler , isdn4linux@listserv.isdn4linux.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20091003120657.2228911186C@xenon.ts.pxnet.com> In-Reply-To: <20091003120657.2228911186C@xenon.ts.pxnet.com> X-Move-Along: Nothing to see here. No, really... Nothing. MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910032026.24451.mb@bu3sch.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 19 On Saturday 03 October 2009 14:06:57 Tilman Schmidt wrote: > Move calls to handle_minor_send() and handle_minor_recv() out of > the sections locked by workaround_lock. > - handle_minor_send() may call another CAPI function via the card > driver, deadlocking by trying to take workaround_lock again. > - handle_minor_recv() calls the receive_buf method of the active > line discipline which may sleep. I remember that handle_minor_send() and/or handle_minor_recv() showed up in the crash backtraces. So if you move them out of the critical section, you can as well remove the lock completely. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/