Date: Sun, 04 Oct 2009 20:58:48 -0700 (PDT)
Message-Id: <20091004.205848.109978798.davem@davemloft.net>
To: david@fries.net
Cc: hancockrwd@gmail.com, linux-kernel@vger.kernel.org, d.stussy@yahoo.com,
       joao.ramos@inov.pt, torvalds@osdl.org, rjw@sisk.pl, vojtech@suse.cz
Subject: Re: [bisected] 2.6.31 regression sis5513 PIO Mode 0 hang
From: David Miller <davem@davemloft.net>
In-Reply-To: <20091005025549.GA32331@spacedout.fries.net>
References: <20091003025415.GA28295@spacedout.fries.net>
	<4AC7F306.2040409@gmail.com>
	<20091005025549.GA32331@spacedout.fries.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1630
Lines: 45

From: David Fries <david@fries.net>
Date: Sun, 4 Oct 2009 21:55:50 -0500

> First, if I'm going to do much debugging, how would I force the
> ethernet device to come up first so I have netconsole?
> 
> How is the problem patch,
> +       ide_port_for_each_dev(i, drive, hwif) {
> +               if (port_ops && port_ops->set_pio_mode)
> +                       port_ops->set_pio_mode(drive, 0);
> +       }
> 
> Different from using hdparm to set the mode?  I do this,
> hdparm -p 0 /dev/hda
> hdparm -X pio0 /dev/hda
> and the benchmarks give me about what I would expect 7MB/s instead of
> the normal 40MB/s.
> 
> Then I can re-enable with,
> hdparm -p 4 /dev/hda
> hdparm -X udma5 /dev/hda
> hdparm -d 1 /dev/hda
> hda: UDMA/100 mode selected
> and the drive is back up to speed, and obviously the kernel didn't
> freeze.  Should there be anything different between what the patch
> tried, and and hdparm's doing, other than kernel initiated and start
> and a user program later on?

>From your original hang trace I can only guess that the problematic
sequence is putting your CDROM into PIO0, then putting it into
PIO4, and then immediately reading the TOC.

This is what the ide-cd.c code does right about where you get the
hang.

Debugging this further is really totally pointless for a subsystem
that should be in deep maintainence mode, so I'm just going to
revert.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/