Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758081AbZJEGrg (ORCPT ); Mon, 5 Oct 2009 02:47:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753679AbZJEGrg (ORCPT ); Mon, 5 Oct 2009 02:47:36 -0400 Received: from brick.kernel.dk ([93.163.65.50]:58494 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133AbZJEGrf (ORCPT ); Mon, 5 Oct 2009 02:47:35 -0400 Date: Mon, 5 Oct 2009 08:46:58 +0200 From: Jens Axboe To: Corrado Zoccolo Cc: Linux-Kernel , Jeff Moyer Subject: Re: cfq: fix possible problem with jiffies wraparound Message-ID: <20091005064657.GP26573@kernel.dk> References: <200910041909.08282.czoccolo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200910041909.08282.czoccolo@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 578 Lines: 17 On Sun, Oct 04 2009, Corrado Zoccolo wrote: > The RR service tree is indexed by a key that is relative to current jiffies. > This can cause problems on jiffies wraparound. > > The patch fixes it using time_before comparison, and changing > the add_front path to use a relative number, too. Good spotting, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/