Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758188AbZJEGu4 (ORCPT ); Mon, 5 Oct 2009 02:50:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755675AbZJEGuz (ORCPT ); Mon, 5 Oct 2009 02:50:55 -0400 Received: from brick.kernel.dk ([93.163.65.50]:58530 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755518AbZJEGuz (ORCPT ); Mon, 5 Oct 2009 02:50:55 -0400 Date: Mon, 5 Oct 2009 08:50:17 +0200 From: Jens Axboe To: Corrado Zoccolo Cc: Linux-Kernel , Jeff Moyer Subject: Re: cfq: fix possible problem with jiffies wraparound Message-ID: <20091005065017.GQ26573@kernel.dk> References: <200910041909.08282.czoccolo@gmail.com> <20091005064657.GP26573@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091005064657.GP26573@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 22 On Mon, Oct 05 2009, Jens Axboe wrote: > On Sun, Oct 04 2009, Corrado Zoccolo wrote: > > The RR service tree is indexed by a key that is relative to current jiffies. > > This can cause problems on jiffies wraparound. > > > > The patch fixes it using time_before comparison, and changing > > the add_front path to use a relative number, too. > > Good spotting, applied. Your mailer seems to screw up your patches, it's white space damaged (tabs are spaces). I hand applied it, but you probably want to check that out and get it fixed. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/