Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbZJEPC0 (ORCPT ); Mon, 5 Oct 2009 11:02:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752223AbZJEPC0 (ORCPT ); Mon, 5 Oct 2009 11:02:26 -0400 Received: from smtp2.ultrahosting.com ([74.213.174.253]:35037 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752067AbZJEPCZ (ORCPT ); Mon, 5 Oct 2009 11:02:25 -0400 Date: Mon, 5 Oct 2009 10:55:49 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Mel Gorman cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Tejun Heo , mingo@elte.hu, rusty@rustcorp.com.au, Pekka Enberg Subject: Re: [this_cpu_xx V4 13/20] this_cpu_ops: page allocator conversion In-Reply-To: Message-ID: References: <20091001212521.123389189@gentwo.org> <20091001212600.068637154@gentwo.org> <20091002151437.GP21906@csn.ul.ie> <20091005094527.GB12681@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1882 Lines: 55 Changes to this patch so far: Index: linux-2.6/mm/page_alloc.c =================================================================== --- linux-2.6.orig/mm/page_alloc.c 2009-10-05 09:49:07.000000000 -0500 +++ linux-2.6/mm/page_alloc.c 2009-10-05 09:48:43.000000000 -0500 @@ -1098,8 +1098,6 @@ static void free_hot_cold_page(struct pa arch_free_page(page, 0); kernel_map_pages(page, 1, 0); - local_irq_save(flags); - pcp = &this_cpu_ptr(zone->pageset)->pcp; migratetype = get_pageblock_migratetype(page); set_page_private(page, migratetype); if (unlikely(wasMlocked)) @@ -1121,6 +1119,8 @@ static void free_hot_cold_page(struct pa migratetype = MIGRATE_MOVABLE; } + local_irq_save(flags); + pcp = &this_cpu_ptr(zone->pageset)->pcp; if (cold) list_add_tail(&page->lru, &pcp->lists[migratetype]); else @@ -3120,7 +3120,8 @@ static struct notifier_block __cpuinitda /* * Allocate per cpu pagesets and initialize them. * Before this call only boot pagesets were available. - * Boot pagesets will no longer be used after this call is complete. + * Boot pagesets will no longer be used by this processorr + * after setup_per_cpu_pageset(). */ void __init setup_per_cpu_pageset(void) { @@ -3232,11 +3233,11 @@ __meminit void setup_pagesets(void) zone->pageset = &per_cpu_var(boot_pageset); /* - * Special pagesets with zero elements so that frees + * Special pagesets with one element so that frees * and allocations are not buffered at all. */ for_each_possible_cpu(cpu) - setup_pageset(per_cpu_ptr(zone->pageset, cpu), 0); + setup_pageset(per_cpu_ptr(zone->pageset, cpu), 1); } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/