Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbZJEQtj (ORCPT ); Mon, 5 Oct 2009 12:49:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754072AbZJEQti (ORCPT ); Mon, 5 Oct 2009 12:49:38 -0400 Received: from xenotime.net ([72.52.64.118]:59092 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753089AbZJEQti (ORCPT ); Mon, 5 Oct 2009 12:49:38 -0400 Date: Mon, 5 Oct 2009 09:41:02 -0700 From: Randy Dunlap To: Anuj Aggarwal Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, svenkatr@ti.com, tony@atomide.com Subject: Re: [PATCH v2] SDMA: Fixing bug in omap_dma_set_global_params() Message-Id: <20091005094102.1385b418.rdunlap@xenotime.net> In-Reply-To: <1254732163-3509-1-git-send-email-anuj.aggarwal@ti.com> References: <1254732163-3509-1-git-send-email-anuj.aggarwal@ti.com> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1894 Lines: 62 On Mon, 5 Oct 2009 14:12:43 +0530 Anuj Aggarwal wrote: > Argument tparams was not being used to program > global register GCR.HI_THREAD_RESERVED. This patch fixes the same. > > Signed-off-by: Anuj Aggarwal > --- > arch/arm/plat-omap/dma.c | 15 +++++++++------ > 1 files changed, 9 insertions(+), 6 deletions(-) Hi, Someone please convert all of this source file to correct kernel-doc notation. Thanks. > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c > index fd3154a..0eb676d 100644 > --- a/arch/arm/plat-omap/dma.c > +++ b/arch/arm/plat-omap/dma.c > @@ -829,10 +829,10 @@ EXPORT_SYMBOL(omap_free_dma); > * > * @param arb_rate > * @param max_fifo_depth > - * @param tparams - Number of thereads to reserve : DMA_THREAD_RESERVE_NORM > - * DMA_THREAD_RESERVE_ONET > - * DMA_THREAD_RESERVE_TWOT > - * DMA_THREAD_RESERVE_THREET > + * @param tparams - Number of threads to reserve : DMA_THREAD_RESERVE_NORM > + * DMA_THREAD_RESERVE_ONET > + * DMA_THREAD_RESERVE_TWOT > + * DMA_THREAD_RESERVE_THREET > */ > void > omap_dma_set_global_params(int arb_rate, int max_fifo_depth, int tparams) > @@ -844,11 +844,14 @@ omap_dma_set_global_params(int arb_rate, int max_fifo_depth, int tparams) > return; > } > > + if (max_fifo_depth == 0) > + max_fifo_depth = 1; > if (arb_rate == 0) > arb_rate = 1; > > - reg = (arb_rate & 0xff) << 16; > - reg |= (0xff & max_fifo_depth); > + reg = 0xff & max_fifo_depth; > + reg |= (0x3 & tparams) << 12; > + reg |= (arb_rate & 0xff) << 16; > > dma_write(reg, GCR); > } > -- --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/