Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755656AbZJFAOy (ORCPT ); Mon, 5 Oct 2009 20:14:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754941AbZJFAOx (ORCPT ); Mon, 5 Oct 2009 20:14:53 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:61254 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754900AbZJFAOx (ORCPT ); Mon, 5 Oct 2009 20:14:53 -0400 Subject: Re: [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special variables syntax From: Steven Rostedt Reply-To: rostedt@goodmis.org To: Frederic Weisbecker Cc: Masami Hiramatsu , Ingo Molnar , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" In-Reply-To: <20091005192609.GB6071@nowhere> References: <20091002214834.30906.86502.stgit@dhcp-100-2-132.bos.redhat.com> <20091002214842.30906.49220.stgit@dhcp-100-2-132.bos.redhat.com> <20091003015444.GE4828@nowhere> <4AC830F0.2010003@redhat.com> <4ACA25D5.10703@redhat.com> <20091005192609.GB6071@nowhere> Content-Type: text/plain; charset="ISO-8859-15" Organization: Kihon Technologies Inc. Date: Mon, 05 Oct 2009 20:12:53 -0400 Message-Id: <1254787973.13160.195.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 38 On Mon, 2009-10-05 at 21:26 +0200, Frederic Weisbecker wrote: > On Mon, Oct 05, 2009 at 12:59:01PM -0400, Masami Hiramatsu wrote: > > As far as I can see in arch/*/include/asm/ptrace.h, all registers start with > > alphabets :-). So, I'd like to suggest renaming sp-vars to '_sp-vars'. > > > > Then, we will have; > > - $local-vars > > > There is a risk of bash collision. I actually prefer the "$" notation. As for bash collision, it is common for shell script writers to be able to distinguish a variable from bash. Yes we can backslash it, or quote it. But when I see a $var it sticks out to me that it is a variable. It's not hard to get around. For example, type: $ echo "hello $DISPLAY"' or $DISPLAY' and see what you get. Makefiles and Perl use '$' for variables those that need to handle it with bash can easily cope with it. So my vote is to keep the '$'. It is the most intuitive to what it means. Just my 0.02? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/