Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755891AbZJFBWQ (ORCPT ); Mon, 5 Oct 2009 21:22:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755253AbZJFBWP (ORCPT ); Mon, 5 Oct 2009 21:22:15 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:46544 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755246AbZJFBWP (ORCPT ); Mon, 5 Oct 2009 21:22:15 -0400 Subject: Re: [PATCH tracing/kprobes v2 4/5] perf: Add perf probe subcommand for kprobe-event setup helper From: Steven Rostedt Reply-To: rostedt@goodmis.org To: Masami Hiramatsu Cc: Frederic Weisbecker , Ingo Molnar , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" In-Reply-To: <4ACA95F8.7020407@redhat.com> References: <20091002214834.30906.86502.stgit@dhcp-100-2-132.bos.redhat.com> <20091002214904.30906.11622.stgit@dhcp-100-2-132.bos.redhat.com> <1254788953.13160.209.camel@gandalf.stny.rr.com> <4ACA95F8.7020407@redhat.com> Content-Type: text/plain Organization: Kihon Technologies Inc. Date: Mon, 05 Oct 2009 21:20:15 -0400 Message-Id: <1254792015.13160.212.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 32 On Mon, 2009-10-05 at 20:57 -0400, Masami Hiramatsu wrote: > Steven Rostedt wrote: > > On Fri, 2009-10-02 at 17:49 -0400, Masami Hiramatsu wrote: > >> diff --git a/tools/perf/Makefile b/tools/perf/Makefile > >> index b5f1953..6dabcf1 100644 > >> --- a/tools/perf/Makefile > >> +++ b/tools/perf/Makefile > >> @@ -419,6 +419,16 @@ ifneq ($(shell sh -c "(echo '\#include '; echo 'int main(void) { Elf * > >> msg := $(error No libelf.h/libelf found, please install libelf-dev/elfutils-libelf-devel); > >> endif > >> > >> +ifneq ($(shell sh -c "(echo '\#include '; echo '\#include '; echo 'int main(void) { Dwarf_Debug dbg; Dwarf_Error err; dwarf_init(0, DW_DLC_READ, 0, 0, &dbg, &err); return (long)dbg; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -ldwarf -lelf -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) > >> + msg := $(warning No libdwarf.h found, disables probe subcommand. Please install libdwarf-dev/libdwarf-devel); > > > > Wow! And I thought my macros were ugly ;-) > > :-) > Maybe, would I better make a separate c file to check this? > Like "autoconf-checkdwarf.c". Nah, I think it is pretty obvious to what it is doing. But then again, I like ugly hacks like the above. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/