Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930AbZJFB0W (ORCPT ); Mon, 5 Oct 2009 21:26:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755915AbZJFB0W (ORCPT ); Mon, 5 Oct 2009 21:26:22 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:38207 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755909AbZJFB0V (ORCPT ); Mon, 5 Oct 2009 21:26:21 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: David Rientjes Subject: Re: [Bug #14141] order 2 page allocation failures in iwlagn Cc: kosaki.motohiro@jp.fujitsu.com, Frans Pop , Mel Gorman , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Pekka Enberg , Reinette Chatre , Bartlomiej Zolnierkiewicz , Karol Lewandowski , linux-mm@kvack.org In-Reply-To: References: <200910052334.23833.elendil@planet.nl> Message-Id: <20091006102110.5F9D.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Tue, 6 Oct 2009 10:25:40 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 27 > On Mon, 5 Oct 2009, Frans Pop wrote: > > > And the winner is: > > 2ff05b2b4eac2e63d345fc731ea151a060247f53 is first bad commit > > commit 2ff05b2b4eac2e63d345fc731ea151a060247f53 > > Author: David Rientjes > > Date: Tue Jun 16 15:32:56 2009 -0700 > > > > oom: move oom_adj value from task_struct to mm_struct > > > > I'm confident that the bisection is good. The test case was very reliable > > while zooming in on the merge from akpm. > > > > I doubt it for two reasons: (i) this commit was reverted in 0753ba0 since > 2.6.31-rc7 and is no longer in the kernel, and (ii) these are GFP_ATOMIC > allocations which would be unaffected by oom killer scores. I agree. this patch is pretty obvious correct. it was reverted by one unfortunately regression. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/