Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbZJFCeU (ORCPT ); Mon, 5 Oct 2009 22:34:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755900AbZJFCeU (ORCPT ); Mon, 5 Oct 2009 22:34:20 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:46043 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754743AbZJFCeT (ORCPT ); Mon, 5 Oct 2009 22:34:19 -0400 Date: Mon, 5 Oct 2009 19:34:01 -0700 From: Sukadev Bhattiprolu To: Oleg Nesterov Cc: Andrew Morton , Daniel Lezcano , Sukadev Bhattiprolu , Linux Containers , roland@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Message-ID: <20091006023401.GA10132@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021954.GC21006@redhat.com> <20091005181255.GE30442@us.ibm.com> <20091005182536.GA943@redhat.com> <20091005193738.GF30442@us.ibm.com> <20091005194415.GA4560@redhat.com> <20091006000631.GA4390@us.ibm.com> <20091006010956.GA28233@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091006010956.GA28233@redhat.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 38 Oleg Nesterov [oleg@redhat.com] wrote: | On 10/05, Sukadev Bhattiprolu wrote: | > | > Oleg Nesterov [oleg@redhat.com] wrote: | > | Sorry for confusion. | > | | > | > But sure, we could use force_sig_info() in caller. | > | | > | Yes, because this makes the code more explicit imho. And we can avoid | > | the further complicatiions in send_signal() path. | > | > Although, one small drawback would be the different behavior for the | > SIGKILL in load_aout_binary() to the container-init itself calling: | > | > kill(getpid(), SIGKILL); | | could you clarify? load_aout_binary(), like other ->load_binary() | methods does send_sig(SIGKILL, current, 0) ? Yes sorry for being cryptic. If we use force_sig_info() in ->load_binary() methods for the SIGKILL, they will, correctly, kill the container-init. But if the container-init itself calls kill(getpid(), SIGKILL), the container-init will not be killed. I was just pointing out the small difference in behavior for the same signal (when we use force_sig_info()). Thanks for fixing the bug. Sukadev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/