Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755220AbZJFHIc (ORCPT ); Tue, 6 Oct 2009 03:08:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754168AbZJFHIc (ORCPT ); Tue, 6 Oct 2009 03:08:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37367 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117AbZJFHIb (ORCPT ); Tue, 6 Oct 2009 03:08:31 -0400 Date: Tue, 06 Oct 2009 09:07:54 +0200 Message-ID: From: Takashi Iwai To: Mike Frysinger Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] firmware: only allow EDD on x86/x86_64 In-Reply-To: <1254808627-3889-1-git-send-email-vapier@gentoo.org> References: <1254808534-3793-1-git-send-email-vapier@gentoo.org> <1254808627-3889-1-git-send-email-vapier@gentoo.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 36 At Tue, 6 Oct 2009 01:57:07 -0400, Mike Frysinger wrote: > > Rather than have the EDD depend on !ia64 (and assuming that only ia64, > x86, x86_64 will be including this Kconfig), have EDD depend on the only > arches which can support this code. This should allow all other arches > to cleanly include the firmware Kconfig. > > Signed-off-by: Mike Frysinger > --- > v2 > - send out the right file this time > > drivers/firmware/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index ebb9e51..7fff33f 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -7,7 +7,7 @@ menu "Firmware Drivers" > > config EDD > tristate "BIOS Enhanced Disk Drive calls determine boot disk" > - depends on !IA64 > + depends on (X86_64 || X86_32) How about "depends on X86" ? Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/