Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932668AbZJFN7Q (ORCPT ); Tue, 6 Oct 2009 09:59:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932658AbZJFN7Q (ORCPT ); Tue, 6 Oct 2009 09:59:16 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:51737 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932656AbZJFN7P (ORCPT ); Tue, 6 Oct 2009 09:59:15 -0400 Date: Tue, 6 Oct 2009 14:58:37 +0100 From: Mark Brown To: "Hennerich, Michael" Cc: Mike Frysinger , Samuel Ortiz , uclinux-dist-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org, Bryan Wu Subject: Re: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver Message-ID: <20091006135836.GA3926@rakim.wolfsonmicro.main> References: <1253682664-27040-1-git-send-email-vapier@gentoo.org> <1254815071-15822-1-git-send-email-vapier@gentoo.org> <20091006115543.GH27168@sirena.org.uk> <8A42379416420646B9BFAC9682273B6D0E3F4348@limkexm3.ad.analog.com> <20091006123658.GA31079@rakim.wolfsonmicro.main> <8A42379416420646B9BFAC9682273B6D0E3F4420@limkexm3.ad.analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8A42379416420646B9BFAC9682273B6D0E3F4420@limkexm3.ad.analog.com> X-Cookie: libc6 is not essential :| User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 26 On Tue, Oct 06, 2009 at 01:55:45PM +0100, Hennerich, Michael wrote: > >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] > >I'm not sure what the association with virtual gpios is? This is all > >separate to gpiolib except in that it would mean that a gpio driver for > >the device would be able to export these interrupts to its clients. > This is what I meant. > So you propose having the MFD Core as well as its subdevs requesting the > ADP5520 IRQ (client->irq) IRQF_SHARED? I think we already excluded us > from using this option when we were asked to move to the NEW threaded > irqs? No, I'm suggesting implementing an IRQ controller driver for the device - register an irq_chip for the interrupt controller on it. Support for doing this on I2C devices was added at pretty much the same time as the IRQ_ONESHOT support. This gives access to all the genirq infrastrure features rather than having to implement a custom IRQ handling stack. Like I say, I'm not sure what you meant when you were talking about virtual gpios. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/