Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758344AbZJFTEz (ORCPT ); Tue, 6 Oct 2009 15:04:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758236AbZJFTEy (ORCPT ); Tue, 6 Oct 2009 15:04:54 -0400 Received: from thunk.org ([69.25.196.29]:47148 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757817AbZJFTEy (ORCPT ); Tue, 6 Oct 2009 15:04:54 -0400 Date: Tue, 6 Oct 2009 15:03:38 -0400 From: Theodore Tso To: Johannes Berg Cc: Ingo Molnar , Linus Torvalds , Dirk Hohndel , Len Brown , Linux Kernel Mailing List Subject: Re: [patch] kbuild: Improve version string logic Message-ID: <20091006190338.GG24677@mit.edu> Mail-Followup-To: Theodore Tso , Johannes Berg , Ingo Molnar , Linus Torvalds , Dirk Hohndel , Len Brown , Linux Kernel Mailing List References: <1254797502.14122.146.camel@dhohndel-mobl.amr.corp.intel.com> <20091006173508.GA4786@elte.hu> <1254854227.22426.37.camel@johannes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254854227.22426.37.camel@johannes.local> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 21 On Tue, Oct 06, 2009 at 08:37:07PM +0200, Johannes Berg wrote: > > I really don't see how it improves visibility (unless you're oblivious > to the difference between long and short strings), but I do know that I > have a few parsers that this will break. > > I think adding the + unconditionally will also break things like > debian's make-kpkg, for instance, since the + would get propagated into > the package version which reserves the + for something else. > > Etc. Can we please make this stuff optional? That's exactly what I'm afraid of. I'd really like to keep the long version AUTOVERSION strings the same, please. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/