Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933574AbZJFWY0 (ORCPT ); Tue, 6 Oct 2009 18:24:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933468AbZJFWSz (ORCPT ); Tue, 6 Oct 2009 18:18:55 -0400 Received: from mail.pxnet.com ([195.227.45.7]:40988 "EHLO mail.pxnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933252AbZJFWSx (ORCPT ); Tue, 6 Oct 2009 18:18:53 -0400 From: Tilman Schmidt Subject: [PATCH 2/4] isdn: accept CAPI Informational Info values as success To: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org CC: Karsten Keil , Karsten Keil , isdn4linux@listserv.isdn4linux.de, i4ldeveloper@listserv.isdn4linux.de Message-ID: <20091006-patch-capi-2.tilman@imap.cc> In-Reply-To: <20091006-patch-capi-0.tilman@imap.cc> References: <20091006-patch-capi-0.tilman@imap.cc> Date: Wed, 7 Oct 2009 00:18:05 +0200 (CEST) X-Spam-Score: -2.137 () AWL,BAYES_00,RDNS_NONE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 33 Info values in the 0x00xx range are defined in the CAPI standard as "Informational, message processed successfully". Therefore a CONNECT_B3_CONF message with an Info value in that range should open an NCCI just as with Info==0. Impact: minor bugfix Signed-off-by: Tilman Schmidt Acked-by: Karsten Keil --- drivers/isdn/capi/capi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c index 2d83524..65bf91e 100644 --- a/drivers/isdn/capi/capi.c +++ b/drivers/isdn/capi/capi.c @@ -603,7 +603,7 @@ static void capi_recv_message(struct capi20_appl *ap, struct sk_buff *skb) if (CAPIMSG_CMD(skb->data) == CAPI_CONNECT_B3_CONF) { u16 info = CAPIMSG_U16(skb->data, 12); // Info field - if (info == 0) { + if ((info & 0xff00) == 0) { mutex_lock(&cdev->ncci_list_mtx); capincci_alloc(cdev, CAPIMSG_NCCI(skb->data)); mutex_unlock(&cdev->ncci_list_mtx); -- 1.6.2.1.214.ge986c -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/