Date: Tue, 6 Oct 2009 23:22:17 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com, greg@kroah.com,
       charles.f.johnson@intel.com, Mark Allyn <mark.a.allyn@intel.com>
Subject: Re: [PATCH] Changes to integrate RAR with SEP and fix RAR problems
Message-ID: <20091006232217.18e3f0f4@lxorguk.ukuu.org.uk>
In-Reply-To: <1254861953-18099-1-git-send-email-mark.a.allyn@intel.com>
References: <1254861953-18099-1-git-send-email-mark.a.allyn@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 897
Lines: 20

> @@ -121,7 +121,7 @@ source "drivers/staging/hv/Kconfig"
>  
>  source "drivers/staging/vme/Kconfig"
>  
> -source "drivers/staging/rar/Kconfig"
> +source "drivers/staging/rar_register/Kconfig"

Its impossible to compare changes in diffs if you move them around and
then diff them. Please don't do that. Produce the diffs using the same
directory - it can move anyway when the thing comes out of staging

If you must move something then do the move and the changes as two
separate patches so it is clear. You do seem to have also done things
like reformatted the code, or worked off an old tree not the kernel one
for the changes which isn't helpful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/