Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbZJGDVn (ORCPT ); Tue, 6 Oct 2009 23:21:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752528AbZJGDVn (ORCPT ); Tue, 6 Oct 2009 23:21:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59066 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbZJGDVm (ORCPT ); Tue, 6 Oct 2009 23:21:42 -0400 Message-ID: <4ACC0963.5080403@redhat.com> Date: Tue, 06 Oct 2009 23:22:11 -0400 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Peter Zijlstra CC: rostedt@goodmis.org, Frederic Weisbecker , Ingo Molnar , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" Subject: Re: [PATCH tracing/kprobes v2 4/5] perf: Add perf probe subcommand for kprobe-event setup helper References: <20091002214834.30906.86502.stgit@dhcp-100-2-132.bos.redhat.com> <20091002214904.30906.11622.stgit@dhcp-100-2-132.bos.redhat.com> <1254788953.13160.209.camel@gandalf.stny.rr.com> <4ACA95F8.7020407@redhat.com> <1254819822.21044.125.camel@laptop> In-Reply-To: <1254819822.21044.125.camel@laptop> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 37 Peter Zijlstra wrote: > On Mon, 2009-10-05 at 20:57 -0400, Masami Hiramatsu wrote: >>>> +ifneq ($(shell sh -c "(echo '\#include '; echo '\#include '; echo 'int main(void) { Dwarf_Debug dbg; Dwarf_Error err; dwarf_init(0, DW_DLC_READ, 0, 0, &dbg, &err); return (long)dbg; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -ldwarf -lelf -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) >>>> + msg := $(warning No libdwarf.h found, disables probe subcommand. Please install libdwarf-dev/libdwarf-devel); >>> >>> Wow! And I thought my macros were ugly ;-) >> >> :-) >> Maybe, would I better make a separate c file to check this? >> Like "autoconf-checkdwarf.c". > > I'm the one who started this trend.. Maybe putting all those tests in a > static .c file makes sense now, put them in a tests/ or checks/ > directory though, so it doesn't litter the regular files. > > Then again,.. the actual .c file is only half that line, so it doesn't > really clean up that much. Yeah, ok, then I'll leave this part in this series. It's better to be done in another series. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/