Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758677AbZJGHO3 (ORCPT ); Wed, 7 Oct 2009 03:14:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758258AbZJGHO2 (ORCPT ); Wed, 7 Oct 2009 03:14:28 -0400 Received: from mail-yw0-f173.google.com ([209.85.211.173]:54377 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756715AbZJGHO1 convert rfc822-to-8bit (ORCPT ); Wed, 7 Oct 2009 03:14:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=M+g/Xz45G9LmynU/HZSk2YuomwQ4zF3u9WlGJ3CedKahAoVsZWYH7X3u1YJaQZ5hD3 iFU+r/hRJrq/vd1eLUQse5HLZunmYGz7U4v5CDgznXSm0euuqGp2OiO9TuYNLBnjO/wA DK+dhrSF5QfyhOHzwq/pg6LC70vIMYzIQMPc0= MIME-Version: 1.0 In-Reply-To: References: <3efb10970910061123k2b6826bci11f0f42509173b26@mail.gmail.com> Date: Wed, 7 Oct 2009 09:13:51 +0200 X-Google-Sender-Auth: 0587aceb2d118994 Message-ID: <3efb10970910070013p447fdd99o22699967a9e51070@mail.gmail.com> Subject: Re: [ANNOUNCE] 2.6.31.2-rt13 From: Remy Bohmer To: Thomas Gleixner Cc: LKML , rt-users Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 50 Hi Thomas, > 2009/10/6 Thomas Gleixner : > On Tue, 6 Oct 2009, Thomas Gleixner wrote: > >> On Tue, 6 Oct 2009, Remy Bohmer wrote: >> > But I was wondering if you missed this one: >> > http://patchwork.kernel.org/patch/50044/ >> >> Yup, slipped through. Queued for the next release. > > Correction. I dropped the patch as it is just a sloppy work around. > Why creating the thread in the first place ? Real fix below. Yeah, I thought about that too. > > Thanks, > > ? ? ? ?tglx > --- > diff --git a/kernel/softirq.c b/kernel/softirq.c > index aae8d45..3526976 100644 > --- a/kernel/softirq.c > +++ b/kernel/softirq.c > @@ -1161,6 +1161,8 @@ static int __cpuinit cpu_callback(struct notifier_block *nfb, > ? ? ? ? ? ? ? ? ? ? ? ?per_cpu(ksoftirqd, hotcpu)[i].tsk = NULL; > ? ? ? ? ? ? ? ?} > ? ? ? ? ? ? ? ?for (i = 0; i < NR_SOFTIRQS; i++) { > + ? ? ? ? ? ? ? ? ? ? ? if (!softirq_names[i]) > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? continue; But I did not do this because I thought this was sloppy as well, I guessed you would never accept a patch that only looks at defining the name, how wrong could I be... ;-) So, going for the cleaner solution, I was going for not defining the HRTIMER_SOFTIRQ in the enum in include/linux/interrupt.h in the first place, but that would touch even more code, and at least that makes clear how much the code is strangled. The loop 'for (i = 0; i < NR_SOFTIRQS; i++)' is used at many more places, would this 'if (!softirq_names[i])' not be required at other places as well? Remy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/