Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932949AbZJGMVO (ORCPT ); Wed, 7 Oct 2009 08:21:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932873AbZJGMVO (ORCPT ); Wed, 7 Oct 2009 08:21:14 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:49918 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932691AbZJGMVN convert rfc822-to-8bit (ORCPT ); Wed, 7 Oct 2009 08:21:13 -0400 Message-Id: <4ACCA3B402000078000187BE@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.1 Date: Wed, 07 Oct 2009 13:20:36 +0100 From: "Jan Beulich" To: "Hugh Dickins" Cc: , "Andrew Morton" , Subject: Re: [PATCH] adjust gfp mask passed on nested vmalloc() invocation References: <4AC9E38E0200007800017F57@vpn.id2.novell.com> <4ACC62DC0200007800018690@vpn.id2.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 18 >>> Hugh Dickins 07.10.09 14:08 >>> >Well, now we've accepted that this code cannot be used in_interrupt(), >there's no need for your #ifdef CONFIG_HIGHMEM nor for my memset: just >use __GFP_ZERO as it was before, and your patch would amount to or'ing >__GFP_HIGHMEM into gfp_mask for the __vmalloc_node case - wouldn't it? Plus the consolidation of masking the passed in gfp_mask by GFP_RECLAIM_MASK also for the nested vmalloc() case, in particular to remove the GFP_DMA* possibly coming in from vmalloc_32(). But yes, it will become simpler. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/