Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758525AbZJGNfv (ORCPT ); Wed, 7 Oct 2009 09:35:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758196AbZJGNfu (ORCPT ); Wed, 7 Oct 2009 09:35:50 -0400 Received: from mail-gx0-f212.google.com ([209.85.217.212]:32994 "EHLO mail-gx0-f212.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756333AbZJGNfl convert rfc822-to-8bit (ORCPT ); Wed, 7 Oct 2009 09:35:41 -0400 MIME-Version: 1.0 In-Reply-To: <1d3f23370910070013u6307bc42hf7ab243b52d007df@mail.gmail.com> References: <1d3f23370910070013u6307bc42hf7ab243b52d007df@mail.gmail.com> From: Grant Likely Date: Wed, 7 Oct 2009 07:34:45 -0600 X-Google-Sender-Auth: 7dee7de3604499b3 Message-ID: Subject: Re: Xilinx SYSACE driver and 8-bit attachment To: John Williams Cc: Linux Kernel list , Michal Simek , John Linn , David DeBonis , Stephen Neuendorffer , devicetree-discuss Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 35 [Added devicetree-discuss to cc: list] On Wed, Oct 7, 2009 at 1:13 AM, John Williams wrote: > Hi Grant (it's your driver :) and David D ( and your DTS generator :) [...] > if (of_find_property(op->node, "8-bit", NULL)) [...] > doesn't match the properties generated by Xilinx's device tree generator: [...] > ??????????????????????? xlnx,mem-width = <0x8>; > > So, the question is, which should change? Well, obviously its a device tree generator bug, the driver code is perfect. :-P In all seriousness though, the '8-bit' property has been present for a while now and needs to be retained to not break existing users. It would be okay for the driver to be modified to *also* check for the xlnx,mem-width property, but the better solution is to modify the device tree generator. Plus, the '8-bit' property is the documented binding in Documentation/powerpc/dts-bindings/xilinx.txt Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/