Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933875AbZJGOnN (ORCPT ); Wed, 7 Oct 2009 10:43:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933372AbZJGOnJ (ORCPT ); Wed, 7 Oct 2009 10:43:09 -0400 Received: from mail-qy0-f202.google.com ([209.85.221.202]:43767 "EHLO mail-qy0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759142AbZJGOnF convert rfc822-to-8bit (ORCPT ); Wed, 7 Oct 2009 10:43:05 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=guEPPXuaD6e0vxEFaMMgAPJOjaSMhZlKQKk0OFLMPd515prmkfkCKLg07HRnslP2IH iDiIixQMmFBa5s64sAZ0sINkZAqDlmJF1IfCg2CSeXP1/JA4yijjEyRQ9x3+FejpdQdj uQaRF/dgI+Sp/4WZAkQVgtT5Z/OhMdvp/JS/Y= MIME-Version: 1.0 In-Reply-To: <20091007043603.GC10204@core.coreip.homeip.net> References: <20090930200746.GA1384@ucw.cz> <20091006050649.GH27881@core.coreip.homeip.net> <20091006075816.GA1362@ucw.cz> <20091007043603.GC10204@core.coreip.homeip.net> From: Eric Miao Date: Wed, 7 Oct 2009 22:42:08 +0800 Message-ID: Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related? To: Dmitry Torokhov Cc: Pavel Machek , rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz, linux-input@vger.kernel.org, "Rafael J. Wysocki" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 44 On Wed, Oct 7, 2009 at 12:36 PM, Dmitry Torokhov wrote: > On Tue, Oct 06, 2009 at 09:58:17AM +0200, Pavel Machek wrote: >> Hi! >> >> On Mon 2009-10-05 22:06:50, Dmitry Torokhov wrote: >> > On Wed, Sep 30, 2009 at 10:07:46PM +0200, Pavel Machek wrote: >> > > >> > > It complains about unbalanced irq 113 wake disable. That one belongs >> > > to matrix-keypad... >> > >> > I guess some of enable_irq_wake()s fail on your box. Do you see it if >> > you apply the patch below? >> >> I'll do short test. But... if you are right, your patch will just make >> your machine refuse to suspend... right? >> >> Ungood. > > It was just a debug patch. > >> >> Actually, it seems to break suspend (returns  -EINVAL while refusing >> to suspend), warnings are still there, and keyboard is dead after >> failed suspend... double plus ungood. >> >> Aha, so warning is solved: the one in the log is from gpio_buttons. >> > > OK, so it looks like your box refuses to set up one of the GPIOs as a > wakeup source... Hmm, either your box is wrong ;) or matrix_keypad > driver needs to maintain a separate list of wakeup GPIOs. > This is due to the nature of PXA processor, where not every GPIO can be configured as a wakeup source. Mmm.... we can either return a pseudo value indicating setting wakeup on that GPIO is OK (which doesn't sound like a good idea), or we can just ignore the failure of enable_irq_wake() in matrix_keypad? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/