Date: Wed, 7 Oct 2009 08:38:36 -0700
From: Randy Dunlap <rdunlap@xenotime.net>
To: Venkatraman S <svenkatr@ti.com>
Cc: Anuj Aggarwal <anuj.aggarwal@ti.com>, linux-omap@vger.kernel.org,
       linux-kernel@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCH v2] SDMA: Fixing bug in omap_dma_set_global_params()
Message-Id: <20091007083836.89b48fbd.rdunlap@xenotime.net>
In-Reply-To: <618f0c910910070218q496eeb9dgf200ffd5d6583aef@mail.gmail.com>
References: <1254732163-3509-1-git-send-email-anuj.aggarwal@ti.com>
	<20091005094102.1385b418.rdunlap@xenotime.net>
	<618f0c910910070218q496eeb9dgf200ffd5d6583aef@mail.gmail.com>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1188
Lines: 41

On Wed, 7 Oct 2009 14:48:26 +0530 Venkatraman S wrote:

> On Mon, Oct 5, 2009 at 10:11 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > On Mon, ?5 Oct 2009 14:12:43 +0530 Anuj Aggarwal wrote:
> >
> >> Argument tparams was not being used to program
> >> global register GCR.HI_THREAD_RESERVED. This patch fixes the same.
> >>
> >> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> >> ---
> >> ?arch/arm/plat-omap/dma.c | ? 15 +++++++++------
> >> ?1 files changed, 9 insertions(+), 6 deletions(-)
> >
> >
> > Hi,
> > Someone please convert all of this source file to correct kernel-doc notation.
> >
> > Thanks.
> >
> 
> I now have this on my TODO list. As a bug fix, shouldn't this be
> pulled in and the doc updates for all the functions can be done as a
> separate patch ?

Yes.  Thanks.

> Anuj,
>  Can you please correct the comments for this function to proper
> format along with your changes ?
> 
> Thanks,
> Venkat.


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/