Subject: Re: [PATCH 3/5] checkpatch: add a blacklist
From: Daniel Walker <dwalker@fifo99.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Krzysztof Halasa <khc@pm.waw.pl>, Andy Whitcroft <apw@canonical.com>,
       Li Zefan <lizf@cn.fujitsu.com>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       Steven Rostedt <rostedt@goodmis.org>
In-Reply-To: <20091007165250.30d8c996@lxorguk.ukuu.org.uk>
References: <1253585691-10987-1-git-send-email-dwalker@fifo99.com>
	 <1253585691-10987-2-git-send-email-dwalker@fifo99.com>
	 <1253585691-10987-3-git-send-email-dwalker@fifo99.com>
	 <4AB86ED1.1040200@cn.fujitsu.com> <20090930152708.GD2957@shadowen.org>
	 <1254406711.18167.88.camel@desktop> <m33a5ww8kn.fsf@intrepid.localdomain>
	 <1254887534.18167.253.camel@desktop> <m3hbubv779.fsf@intrepid.localdomain>
	 <1254925617.18167.262.camel@desktop> <m3skdvtgas.fsf@intrepid.localdomain>
	 <1254927438.18167.275.camel@desktop>
	 <20091007161107.72b4031b@lxorguk.ukuu.org.uk>
	 <1254930068.18167.304.camel@desktop>
	 <20091007165250.30d8c996@lxorguk.ukuu.org.uk>
Content-Type: text/plain
Date: Wed, 07 Oct 2009 09:11:27 -0700
Message-Id: <1254931887.18167.309.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1435
Lines: 34

On Wed, 2009-10-07 at 16:52 +0100, Alan Cox wrote:
> On Wed, 07 Oct 2009 08:41:08 -0700
> Daniel Walker <dwalker@fifo99.com> wrote:
> 
> > On Wed, 2009-10-07 at 16:11 +0100, Alan Cox wrote:
> > > > Right it's a tool .. However, you should use it and you should follow
> > > > it. If for some reason you disagree with the tool you have to give at
> > > > least an arguable reason why, not just "It's a guide", "I don't like the
> > > > coding style." etc..
> > > 
> > > Those are perfectly good reasons.
> > 
> > I don't think they are.. Like adding spaces for tabs is ok cause
> > checkpatch is a guide right?
> 
> Yes.. if it was such a big deal someone would have updated the git commit
> tools to fix them as we do to strim off trailing spaces.
> 
> They have *zero* impact on performance, maintainability or readability
> providing they don't mess up the indentation - and the kernel is full of
> them.

It has an impact on maintainability and readability.. Take a source file
with tabs, then remove all the tabs and insert spaces. It's pretty
annoying and I would not want to touch code like that. Trailing
whitespace is a lot less annoying than using spaces instead of tabs.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/