DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=LZrg5fWVOmXg8okwynQQ3eKE8bE0gC39TrzuuRG0UUj9lip/9LzXNFPLFSlmclxpuz
         CsN+aO1LpXhxnudmQ6s0d7/ouMV69KNrZWfy5Zn+zaqWijHiQh1RQzXGIH54WGJT0ST6
         ViCHNStpK656gYyeHpocWwikr/unlqEp1k9Kw=
MIME-Version: 1.0
In-Reply-To: <20091006213349.4272.65914.stgit@bob.kio>
References: <20091006213259.4272.68068.stgit@bob.kio>
	 <20091006213349.4272.65914.stgit@bob.kio>
Date: Wed, 7 Oct 2009 11:43:09 -0700
Message-ID: <86802c440910071143y7ba8b0f8y9efff738eba9d30b@mail.gmail.com>
Subject: Re: [PATCH 5/7] x86/PCI: print resources consistently with %pRt
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>, linux-pci@vger.kernel.org,
       linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1471
Lines: 39

On Tue, Oct 6, 2009 at 2:33 PM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> This uses %pRt to print additional resource information (type, size,
> prefetchability, etc.) consistently.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
> ?arch/x86/pci/acpi.c | ? 14 +++++++++++---
> ?arch/x86/pci/i386.c | ? 12 +++++-------
> ?2 files changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
> index 2297280..4d4f1df 100644
> --- a/arch/x86/pci/acpi.c
> +++ b/arch/x86/pci/acpi.c
> @@ -7,6 +7,7 @@
> ?#include <asm/pci_x86.h>
>
> ?struct pci_root_info {
> + ? ? ? struct acpi_device *bridge;
> ? ? ? ?char *name;
> ? ? ? ?unsigned int res_num;
> ? ? ? ?struct resource *res;
> @@ -107,12 +108,18 @@ setup_resource(struct acpi_resource *acpi_res, void *data)
> ? ? ? ?res->child = NULL;
>
> ? ? ? ?if (insert_resource(root, res)) {
> - ? ? ? ? ? ? ? printk(KERN_ERR "PCI: Failed to allocate 0x%lx-0x%lx "
> - ? ? ? ? ? ? ? ? ? ? ? "from %s for %s\n", (unsigned long) res->start,
> - ? ? ? ? ? ? ? ? ? ? ? (unsigned long) res->end, root->name, info->name);
> + ? ? ? ? ? ? ? dev_err(&info->bridge->dev, "can't allocate %pRt\n", res);

better to keep that root name ?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/