Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751221AbZJGVFU (ORCPT ); Wed, 7 Oct 2009 17:05:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750862AbZJGVFU (ORCPT ); Wed, 7 Oct 2009 17:05:20 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:46543 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750833AbZJGVFT (ORCPT ); Wed, 7 Oct 2009 17:05:19 -0400 Date: Wed, 7 Oct 2009 22:05:43 +0100 From: Alan Cox To: Jiri Slaby Cc: Alan Cox , linux-kernel@vger.kernel.org, strakh@ispras.ru Subject: Re: [PATCH 2/4] isicom: switch to the new tty_port_open helper Message-ID: <20091007220543.2d1864db@lxorguk.ukuu.org.uk> In-Reply-To: <4ACCF5D5.7010505@gmail.com> References: <20091007144455.14550.95003.stgit@localhost.localdomain> <20091007144621.14550.62068.stgit@localhost.localdomain> <4ACCF5D5.7010505@gmail.com> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 20 On Wed, 07 Oct 2009 22:11:01 +0200 Jiri Slaby wrote: > On 10/07/2009 04:46 PM, Alan Cox wrote: > > - if (port->port.flags & ASYNC_INITIALIZED) > > - return 0; > > - if (tty_port_alloc_xmit_buf(&port->port) < 0) > > + if (tty_port_alloc_xmit_buf(tport) < 0) > > I think this won't work well with 1/4. ->activate is called with > port->port.mutex (the name in this context), but tty_port_alloc_xmit_buf > wants it again. Indeed - so the port buffer allocation stuff wants revisiting. I'll do that tomorrow. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/