Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755276AbZJGXBo (ORCPT ); Wed, 7 Oct 2009 19:01:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754956AbZJGXBn (ORCPT ); Wed, 7 Oct 2009 19:01:43 -0400 Received: from kroah.org ([198.145.64.141]:42186 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754736AbZJGXBn (ORCPT ); Wed, 7 Oct 2009 19:01:43 -0400 Date: Wed, 7 Oct 2009 15:58:28 -0700 From: Greg KH To: Mike Lothian Cc: linux-kernel , Matthias Hopf , Matthew Garrett Subject: Re: Samsung Backlight Patch Message-ID: <20091007225828.GA7892@kroah.com> References: <20091007211916.GA4217@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 52 On Wed, Oct 07, 2009 at 10:31:44PM +0100, Mike Lothian wrote: > 2009/10/7 Greg KH : > > On Wed, Oct 07, 2009 at 10:14:37PM +0100, Mike Lothian wrote: > >> Hi > >> > >> I was hoping the following patch could be included in 2.6.32 so it > >> would hopefully end up in the next round of distros > >> > >> It adds backlight support for some Samsung laptops > > > > You seem to have lost the original authorship of this patch, and not > > included your signed-off-by for it. > > > > Which means it can't be applied :( > > > > thanks, > > > > greg k-h > > > > It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman > "); at the bottom > > I certainly wasn't trying to steal credit for your work I mean on the patch, when submitting it, you need a: From: Greg Kroah-Hartman as the first line. > Who should sign it off? As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain. Someone needs to sign off on it... > I think there's a few other models that can be added to this patch too I do too. Note, if you look at the git tree I have for the driver, it is totally rewritten to not use a structure, and instead, use offsets properly. But it removed support for your laptop, which is not what you probably want :( thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/