Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756718AbZJHJZV (ORCPT ); Thu, 8 Oct 2009 05:25:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756390AbZJHJZU (ORCPT ); Thu, 8 Oct 2009 05:25:20 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:58130 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756328AbZJHJZT (ORCPT ); Thu, 8 Oct 2009 05:25:19 -0400 Date: Thu, 8 Oct 2009 11:24:33 +0200 From: Pavel Machek To: Trilok Soni Cc: dtor@mail.ru, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, kernel list , Andrew Morton Subject: Re: ads7846 touchscreen: fix pressure Message-ID: <20091008092433.GA26837@elf.ucw.cz> References: <20091006195413.GA1469@ucw.cz> <5d5443650910072209t63e3fa9dvff7ab2fee7bb2f88@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5d5443650910072209t63e3fa9dvff7ab2fee7bb2f88@mail.gmail.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 37 On Thu 2009-10-08 10:39:39, Trilok Soni wrote: > Hi Pavel, > > On Wed, Oct 7, 2009 at 1:24 AM, Pavel Machek wrote: > > > > On Zaurus, pressure is reported inverted -- the lighter the pressure, > > the bigger numerical value. This should fix it. > > > > Signed-off-by: Pavel Machek > > > > --- linux-rc/drivers/input.ofic/touchscreen/ads7846.c ? 2009-10-06 13:49:56.000000000 +0200 > > +++ linux-rc/drivers/input/touchscreen/ads7846.c ? ? ? ?2009-10-06 21:18:25.000000000 +0200 > > @@ -608,12 +609,12 @@ > > > > ? ? ? ? ? ? ? ?input_report_abs(input, ABS_X, x); > > ? ? ? ? ? ? ? ?input_report_abs(input, ABS_Y, y); > > - ? ? ? ? ? ? ? input_report_abs(input, ABS_PRESSURE, Rt); > > + ? ? ? ? ? ? ? input_report_abs(input, ABS_PRESSURE, ts->pressure_max-Rt); > > but same behavior is seen by others using this chip on different > boards? If not, this has to be done through platform data. Well, I'd expect the chip to behave in similar way on all platforms. Of course, it would be good if someone with different hw tested it, but I do not have that hw... So I guess the best way is to make it go in early and see how it does in testing.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/