Date: Thu, 8 Oct 2009 08:06:15 -0700
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
       linux-wireless@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>,
       linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE
Message-Id: <20091008080615.09c8b803.randy.dunlap@oracle.com>
In-Reply-To: <1254995282.3713.18.camel@johannes.local>
References: <20091007105720.a2457e5b.randy.dunlap@oracle.com>
	<1254949672-24022-1-git-send-email-linville@tuxdriver.com>
	<4ACD0E5A.7060106@oracle.com>
	<1254954842.3713.7.camel@johannes.local>
	<4ACD1C3D.3030506@oracle.com>
	<1254957256.3713.10.camel@johannes.local>
	<20091007171235.d40f0cc2.randy.dunlap@oracle.com>
	<1254995282.3713.18.camel@johannes.local>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1720
Lines: 60

On Thu, 08 Oct 2009 11:48:02 +0200 Johannes Berg wrote:

> On Wed, 2009-10-07 at 17:12 -0700, Randy Dunlap wrote:
> 
> > > > # CONFIG_WIRELESS is not set
> > > > CONFIG_WIRELESS_EXT=y
> > > > CONFIG_WEXT_SPY=y
> > > > CONFIG_WEXT_PRIV=y
> > > > 
> > > > WEXT_CORE is not enabled.  I haven't found the culprit, but I suspect "select".
> > > 
> > > Interesting.
> > > 
> > > > but what in WIRELESS_EXT would also cause WEXT_CORE to be enabled?
> > > 
> > > Well, the way WEXT_CORE is defined as def_bool y ought to, no?
> > 
> > Ah, I see what you mean.
> > 
> > Here's what's happening:
> > 
> > net/wireless/Kconfig says:
> > 
> > config WEXT_CORE
> > 	def_bool y
> > 	depends on CFG80211_WEXT || WIRELESS_EXT
> > 
> > 
> > and net/Kconfig says:
> > 
> > if WIRELESS
> > 
> > source "net/wireless/Kconfig"
> > source "net/mac80211/Kconfig"
> > 
> > endif # WIRELESS
> > 
> > 
> > so WEXT_CORE actually depends on NET && WIRELESS && (CFG80211_WEXT || WIRELESS_EXT)
> > (that's what xconfig shows me).
> > But WIRELESS is not enabled.  Pooh.
> > 
> > I was already toying with making CONFIG_WIRELESS a real/usable kconfig symbol.
> > That may have to be done unless someone else comes up with another solution.
> 
> Ah!
> 
> It's kinda strange though that you can select wireless drivers without
> selecting WIRELESS. Maybe the solution is as simple as making WLAN
> (drivers/net/wireless/Kconfig) depend on WIRELESS?

Yes, I think that would be a very good start.

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/