Date: Thu, 8 Oct 2009 17:53:44 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>, Avi Kivity <avi@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       "hugh.dickins" <hugh.dickins@tiscali.co.uk>,
       David Howells <dhowells@redhat.com>,
       lkml <linux-kernel@vger.kernel.org>,
       linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [RFC][PATCH] kmap_atomic_push
Message-ID: <20091008155344.GA11727@elte.hu>
References: <1255016123.17055.17.camel@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1255016123.17055.17.camel@laptop>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1077
Lines: 27


* Peter Zijlstra <peterz@infradead.org> wrote:

> The below patchlet changes the kmap_atomic interface to a stack based 
> one that doesn't require the KM_types anymore.
> 
> This significantly simplifies some code (more still than are present 
> in this patch -- ie. pte_map_nested can go now)
> 
> This obviously requires that push and pop are matched, I fixed a few 
> cases that were not properly nested, the (x86) code checks for this 
> and will go BUG when trying to pop a vaddr that isn't the top one so 
> abusers should be rather visible.

Looks great IMO! Last i proposed this i think either Andrew or Avi had 
second thoughts about the hard-to-calculate worst-case mapping limit - 
but i dont think that's a big issue.

Lets not change the API names though - the rule is that map/unmap must 
be properly nested.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/