Date: Thu, 8 Oct 2009 22:32:02 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nick Bowler <nbowler@elliptictech.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com, gregkh@suse.de
Subject: Re: [Regression, bisected] Transmit failure in et131x.
Message-ID: <20091008223202.6e1b1303@lxorguk.ukuu.org.uk>
In-Reply-To: <20091008140805.GA21535@emergent.ellipticsemi.com>
References: <20091008140805.GA21535@emergent.ellipticsemi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1094
Lines: 25

> I bisected the problem to the following commit.  The WARN messages and
> bisection log are at the end of this email.
> 
> 356c74b401f6b05ae5d793e9d1a9ba8297b8e3ff is first bad commit
> commit 356c74b401f6b05ae5d793e9d1a9ba8297b8e3ff
> Author: Alan Cox <alan@linux.intel.com>
> Date:   Thu Aug 27 11:01:57 2009 +0100

Thanks. I'll go through that patch again see what I broke on your card.
Probably a wrapping bug with a long queue that my box for some reason
didn't manage to hit.

> Oct  5 23:37:53 aphrodite WARNING: at net/sched/sch_generic.c:261 dev_watchdog+0x13c/0x1fd()
> Oct  5 23:37:53 aphrodite Hardware name: System Product Name
> Oct  5 23:37:53 aphrodite NETDEV WATCHDOG: eth0 (et131x): transmit queue 0 timed out

That is the important bit. The rest is fall out from the fact the driver
doesn't recover properly when it fails.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/