Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759187AbZJINLk (ORCPT ); Fri, 9 Oct 2009 09:11:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753366AbZJINLk (ORCPT ); Fri, 9 Oct 2009 09:11:40 -0400 Received: from fifo99.com ([67.223.236.141]:44052 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbZJINLj (ORCPT ); Fri, 9 Oct 2009 09:11:39 -0400 Subject: Re: [GIT PULL] SCSI fixes for 2.6.32-rc3 From: Daniel Walker To: Ingo Molnar Cc: Linus Torvalds , Greg Kroah-Hartman , Theodore Tso , James Bottomley , Andrew Morton , linux-scsi , linux-kernel , Jing Huang In-Reply-To: <20091009091538.GA4154@elte.hu> References: <1254862442.4383.183.camel@mulgrave.site> <1255012399.4187.24.camel@mulgrave.site> <1255031298.4187.260.camel@mulgrave.site> <20091008210737.GD29181@mit.edu> <20091009091538.GA4154@elte.hu> Content-Type: text/plain Date: Fri, 09 Oct 2009 06:10:10 -0700 Message-Id: <1255093810.18167.398.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 29 On Fri, 2009-10-09 at 11:15 +0200, Ingo Molnar wrote: > > I dont know what's the current mainline inclusion quality threshold for > non-staging Linux drivers - it might be ok. Also, the driver commit has > been rebased a few days ago which makes it hard to see its stability > track record. > > Ingo > > ---------------> > ERROR: return is not a function, parentheses are not required > #191: FILE: fcbuild.c:191: > + return (FC_PARSE_BUSY); The author submitted a basic style clean up here, http://patchwork.kernel.org/patch/50161/ It was a series that did the whole driver.. I'm not sure why those patches aren't included, but at least there was an attempt at cleaning the driver up.. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/