Return-Path: <linux-kernel-owner+w=401wt.eu-S933553AbZJIRbR@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933553AbZJIRbR (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2009 13:31:17 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761127AbZJIRbQ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 9 Oct 2009 13:31:16 -0400
Received: from fg-out-1718.google.com ([72.14.220.152]:62193 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755137AbZJIRbP convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2009 13:31:15 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=aLiCr8RjMPKAYhqbnwy6yEW5gaEzZbwQZtv/sM4UKa+NS/wy3Q1nQgAXsr+dDFd4EP
         krCsoFkD/lz/cQCkiktAgckdMQ3LyyWN6oqV+3TX859KWaEgJZ56ag5dltCNVcb+bxnj
         kPTqdvQDRkikIq0MfOHFpphl6Hp4d+i1Qw1TI=
MIME-Version: 1.0
In-Reply-To: <20091009144840.GA9561@suse.de>
References: <20091007185112.GJ7899@atomide.com>
	 <94a0d4530910081429m7ad88b43q38245109f3252078@mail.gmail.com>
	 <20091008214140.GJ7417@atomide.com>
	 <94a0d4530910081513w1a919dc2s50eca41966a2261d@mail.gmail.com>
	 <94a0d4530910081520t66ce7567xe142979a35b1245@mail.gmail.com>
	 <20091008232603.GB25892@atomide.com>
	 <94a0d4530910090508o1e3d19cew881d2eb348199674@mail.gmail.com>
	 <20091009144840.GA9561@suse.de>
Date: Fri, 9 Oct 2009 20:29:24 +0300
Message-ID: <94a0d4530910091029p12f8c28fve91e95db533e78e5@mail.gmail.com>
Subject: Re: [GIT PULL] omap fixes for v2.6.32-rc3
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Tony Lindgren <tony@atomide.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
       Denis Karpov <ext-denis.2.karpov@nokia.com>,
       "Uwe Kleine-K??nig" <u.kleine-koenig@pengutronix.de>,
       Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2870
Lines: 71

On Fri, Oct 9, 2009 at 5:48 PM, Greg KH <gregkh@suse.de> wrote:
> On Fri, Oct 09, 2009 at 03:08:00PM +0300, Felipe Contreras wrote:
>> On Fri, Oct 9, 2009 at 2:26 AM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Felipe Contreras <felipe.contreras@gmail.com> [091008 15:20]:
>>
>> <snip/>
>>
>> >> > Here you can see Uwe Kleine-K??nig sending the original patch without
>> >> > even CC'ing the mmc list:
>> >> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
>> >> >
>> >> > And it was unintentionally broken by this one:
>> >> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
>> >>
>> >> Er, actually that one was ok, the problem was introduced only in the
>> >> final version:
>> >> http://marc.info/?l=linux-mmc&m=125366315417006&w=2
>> >
>> > Right, looks like Roger forgot to Cc linux-mmc.
>> >
>> >> > I don't see what we are waiting for, the code is clearly broken, even
>> >> > the compiler warns that nobody is using omap_hsmmc_probe().
>> >
>> > I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
>> > merged soon:
>> >
>> > http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg00539.html
>>
>> I don't see what's specific about mmc in that patch, nor omap. It's
>> just a fix for an obvious mistake that must be picked ASAP and can't
>> possibly be NAK'ed.
>>
>> There's a tree for trivial fixes:
>> git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
>>
>> And one for includecheck:
>> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
>>
>> What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew
>> Morton because I think they might interested in fixing these kinds of
>> issues quickly in the future.
>
> What kind of issues?  Why would I be interested, where is the problem?

The obvious-brain-dead-duh kind of issues, like this one.

The problem is that OMAP devices (like beagleboard) are not booting
correctly right now because of a wrong merge. It has been identified,
tested, and acked, but nobody has picked it up for a pull request, so
it's not clear it will be on -rc4.

To me it's not clear who should push the patch, it seems it doesn't
belong on linux-omap, so Tony is pushing it through linux-mmc, which I
don't think is the right place. They should be handling mmc-related
issues, not obvious breakage.

In order to keep the engines oiled I think there must be a process to
flag obvious generic breakage so it's immediately picked; maybe an
'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial',
'includecheck', and similar, or maybe nothing needs to be done. Up to
you to decide.

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/